From: Peter Zijlstra <peterz@infradead.org>
To: David Brownell <david-b@pacbell.net>
Cc: linux-usb-devel@lists.sourceforge.net, Greg KH <greg@kroah.com>,
Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oneukum@suse.de>, Ingo Molnar <mingo@elte.hu>,
Stephen Hemminger <shemminger@linux-foundation.org>,
linux-kernel@vger.kernel.org, apw <apw@shadowen.org>
Subject: Re: [linux-usb-devel] device struct bloat
Date: Tue, 06 Nov 2007 10:43:42 +0100 [thread overview]
Message-ID: <1194342222.6544.20.camel@twins> (raw)
In-Reply-To: <200711051738.35080.david-b@pacbell.net>
On Mon, 2007-11-05 at 17:38 -0800, David Brownell wrote:
> On Monday 05 November 2007, Greg KH wrote:
> > --- linux-2.6-2.orig/drivers/spi/spi.c
> > +++ linux-2.6-2/drivers/spi/spi.c
>
> It'd be quicker to end up in the right hands if you had
> split this big and random patch according to subsystem...
Yeah, sorry, I just started converting mindlessly and stopped once it
compiled (which explains the missing FW bits, I don't have that in my
config). Then booted and fixed up what broke, well aside from the final
lockdep issue. As I couldn't get that fixed, I never looked twice,
didn't make it a proper patch-set, nor validated the rest of the patch.
Wasn't even planning on sending it out initially.
> There's already a patch in the MM queue that removes
> the SPI-private semaphore. Except that it's missing
> the bug noted below.
Right, lack of a recent -mm made me work against mainline. I'm sure I
would've noticed otherwise :-)
next prev parent reply other threads:[~2007-11-06 9:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 19:48 device struct bloat Stephen Hemminger
2007-11-03 23:14 ` Greg KH
2007-11-04 20:29 ` Peter Zijlstra
2007-11-05 3:58 ` Greg KH
2007-11-05 10:46 ` Peter Zijlstra
2007-11-05 10:57 ` Peter Zijlstra
2007-11-05 22:33 ` Stefan Richter
2007-11-05 22:49 ` Greg KH
2007-11-06 1:38 ` [linux-usb-devel] " David Brownell
2007-11-06 9:43 ` Peter Zijlstra [this message]
2007-11-06 9:48 ` Peter Zijlstra
2007-11-06 15:36 ` Alan Stern
2007-11-06 15:58 ` Peter Zijlstra
2007-11-06 16:32 ` Alan Stern
2007-11-06 17:19 ` Peter Zijlstra
2007-11-06 18:05 ` Alan Stern
2007-11-06 18:57 ` Peter Zijlstra
2007-11-07 16:42 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194342222.6544.20.camel@twins \
--to=peterz@infradead.org \
--cc=apw@shadowen.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=mingo@elte.hu \
--cc=oneukum@suse.de \
--cc=shemminger@linux-foundation.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox