Re: [PATCH] x86: unification of cfufreq/Kconfig

Adrian Bunk
2007-11-08T14:51:55Z

On Wed, Nov 07, 2007 at 05:06:29PM +0100, Sam Ravnborg wrote:
> On Wed, Nov 07, 2007 at 08:18:01AM +0100, Adrian Bunk wrote:
> > On Wed, Nov 07, 2007 at 08:06:44AM +0100, Sam Ravnborg wrote:
> > > On Wed, Nov 07, 2007 at 07:02:20AM +0100, Adrian Bunk wrote:
> > > > On Wed, Nov 07, 2007 at 12:01:12AM +0100, Sam Ravnborg wrote:
> > > > >...
> > > > > config X86_SPEEDSTEP_CENTRINO
> > > > > - tristate "Intel Enhanced SpeedStep"
> > > > > + tristate "Intel Enhanced SpeedStep (deprecated)"
> > > > > select CPU_FREQ_TABLE
> > > > > - select X86_SPEEDSTEP_CENTRINO_TABLE
> > > > > + select X86_SPEEDSTEP_CENTRINO_TABLE if X86_32
> > > > > + depends on X86_64 && ACPI_PROCESSOR
> > > > >...
> > > >
> > > > No.
> > > >
> > > > depends on ACPI_PROCESSOR if X86_64
> > >
> > > Gives syntax error.
> >
> > That happens when you review something without trying it...
> >
> > depends on (ACPI_PROCESSOR || !X86_64)
>
> Got confused by the if and did the wrong conversion.
> To make it look like the other config options I will use:
>
> depends on X86_64 || (X86_32 && ACPI_PROCESSOR)
>
> It is longer but simpler.

But wrong...

depends on X86_32 || (X86_64 && ACPI_PROCESSOR)

> Thanks,
> Sam

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed