From: Paul Albrecht <albrecht@rdi1.com>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: David Howells <dhowells@redhat.com>,
akpm@linux-foundation.org, unionfs@filesystems.org,
linux-kernel@vger.kernel.org
Subject: Re: [Unionfs] Re: [PATCH] IGET: Stop UnionFS from using iget() and read_inode()
Date: Wed, 07 Nov 2007 08:31:51 -0600 [thread overview]
Message-ID: <1194445911.2705.2.camel@albrecht.rdi1.com> (raw)
In-Reply-To: <200711070644.lA76iodZ005491@agora.fsl.cs.sunysb.edu>
On Wed, 2007-11-07 at 01:44 -0500, Erez Zadok wrote:
> In message <20071106145234.4807.69325.stgit@warthog.procyon.org.uk>, David Howells writes:
> > From: David Howells <dhowells@redhat.com>
> >
> > Stop the UnionFS filesystem from using iget() and read_inode(). Replace
> > unionfs_read_inode() with unionfs_iget(), and call that instead of iget().
> > unionfs_iget() then uses iget_locked() directly and returns a proper error code
> > instead of an inode in the event of an error.
> >
> > unionfs_fill_super() returns any error incurred when getting the root inode
> > instead of EINVAL.
> >
> > Signed-off-by: David Howells <dhowells@redhat.com>
> [...]
>
> Thanks. I tested this code and it passed all my tests. I'll shortly submit
> a slightly revised patch which applies cleanly against the unionfs code in
> -mm.
Does your test set include readahead-list? I can't get it to work with a
union mounted filesystem without segfault'ing and kernel oops'ing.
Paul Albrecht
next prev parent reply other threads:[~2007-11-07 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 14:52 [PATCH] IGET: Stop UnionFS from using iget() and read_inode() David Howells
2007-11-07 6:44 ` Erez Zadok
2007-11-07 14:31 ` Paul Albrecht [this message]
2007-11-07 15:04 ` [Unionfs] " David Howells
2007-11-07 15:14 ` Paul Albrecht
2007-11-07 16:34 ` David Howells
2007-11-07 18:30 ` Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194445911.2705.2.camel@albrecht.rdi1.com \
--to=albrecht@rdi1.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ezk@cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=unionfs@filesystems.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox