public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Romano Giannetti <romanol@upcomillas.es>
To: Roland Dreier <roland@digitalvampire.org>
Cc: Willy Tarreau <w@1wt.eu>, Pierre Ossman <drzeus-mmc@drzeus.cx>,
	linux-kernel@vger.kernel.org, jens.axboe@oracle.com
Subject: Re: *SPAM* Re: 2.6.34-rc1 eat my photo SD card :-(
Date: Thu, 08 Nov 2007 09:46:07 +0100	[thread overview]
Message-ID: <1194511567.7115.1.camel@rukbat> (raw)
In-Reply-To: <87zlxpzkxh.fsf@shaolin.home.digitalvampire.org>


On Wed, 2007-11-07 at 15:37 -0800, Roland Dreier wrote:
> .
> 
> Pierre, assuming Romano tests this patch successfully, please apply!
> 

Hi, the patch below solves the problem with my SD card. 

Tested-by: Romano Giannetti <romano.giannetti@gmail.com>

Thanks!

	Romano

> <-- patch below -->
> 
> mmc: Fix sg helper copy-and-paste error
> 
> Commit 45711f1a ("[SG] Update drivers to use sg helpers") had the
> following bogus change in drivers/mmc/card/queue.c:
> 
>     > -			src_buf = page_address(src->page) + src->offset;
>     > +			src_buf = sg_virt(dst);
> 
> (Notice that "src" is converted to "dst").  Turn this "dst" back into
> the intended "src".
> 
> Cc: Jens Axboe <jens.axboe@oracle.com>
> Signed-off-by: Roland Dreier <roland@digitalvampire.org>
> ---
> diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c
> index 9203a0b..1b9c9b6 100644
> --- a/drivers/mmc/card/queue.c
> +++ b/drivers/mmc/card/queue.c
> @@ -310,7 +310,7 @@ static void copy_sg(struct scatterlist *dst, unsigned int dst_len,
>  		}
>  
>  		if (src_size == 0) {
> -			src_buf = sg_virt(dst);
> +			src_buf = sg_virt(src);
>  			src_size = src->length;
>  		}
>  
-- 
Sorry for the disclaimer --- ¡I cannot stop it!



--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración.

This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation. 

  parent reply	other threads:[~2007-11-08  9:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-01 11:56 2.6.34-rc1 eat my photo SD card :-( Romano Giannetti
2007-11-01 11:35 ` Nick Piggin
2007-11-01 17:17 ` Chuck Ebbert
2007-11-02 17:39   ` Pierre Ossman
2007-11-02 17:28 ` Pierre Ossman
2007-11-04  9:29   ` Romano Giannetti
2007-11-04 16:11     ` Roland Dreier
2007-11-05  7:31       ` Pierre Ossman
2007-11-05 10:51       ` Romano Giannetti
2007-11-05 12:22         ` Pierre Ossman
2007-11-05 13:46           ` Romano Giannetti
2007-11-05 15:26             ` Pierre Ossman
2007-11-05 17:18               ` Romano Giannetti
2007-11-06  9:58               ` Romano Giannetti
2007-11-06 10:28                 ` Romano Giannetti
2007-11-06 19:51                 ` Willy Tarreau
2007-11-06 21:02                   ` Romano Giannetti
2007-11-06 21:48                   ` Romano Giannetti
2007-11-06 22:17                     ` Romano Giannetti
2007-11-07  6:09                       ` Willy Tarreau
2007-11-07 21:52                       ` Romano Giannetti
2007-11-07 23:37                         ` Roland Dreier
2007-11-08  5:54                           ` Pierre Ossman
2007-11-08  7:01                           ` Jens Axboe
2007-11-10 10:32                             ` Pierre Ossman
2007-11-08  8:46                           ` Romano Giannetti [this message]
2007-11-08 17:13                             ` *SPAM* " Roland Dreier
2007-11-08 17:43                               ` Jens Axboe
2007-11-08  0:52                         ` Rafael J. Wysocki
2007-11-05 13:51           ` Romano Giannetti
2007-11-05 15:25             ` Pierre Ossman
2007-11-05  7:30     ` Pierre Ossman
2007-11-07 22:09 ` Joshua Doll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1194511567.7115.1.camel@rukbat \
    --to=romanol@upcomillas.es \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@digitalvampire.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox