From: Peter Zijlstra <peterz@infradead.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch 01/28] cpu alloc: The allocator
Date: Thu, 08 Nov 2007 13:37:39 +0100 [thread overview]
Message-ID: <1194525459.6289.148.camel@twins> (raw)
In-Reply-To: <1194525257.6289.145.camel@twins>
On Thu, 2007-11-08 at 13:34 +0100, Peter Zijlstra wrote:
> On Tue, 2007-11-06 at 11:51 -0800, Christoph Lameter wrote:
> > +#ifndef _LINUX_CPU_ALLOC_H_
> > +#define _LINUX_CPU_ALLOC_H_
> > +
> > +#define CPU_OFFSET(__cpu) \
> > + ((unsigned long)(__cpu) << (CONFIG_CPU_AREA_ORDER + PAGE_SHIFT))
> > +
> > +#define CPU_PTR(__p, __cpu) ((__typeof__(__p))((void *)(__p) + \
> > + CPU_OFFSET(__cpu)))
> > +
> > +#define CPU_ALLOC(type, flags) cpu_alloc(sizeof(type), flags, \
> > + __alignof__(type))
> > +#define CPU_FREE(pointer) cpu_free(pointer, sizeof(*(pointer)))
> > +
> > +#define THIS_CPU(__p) CPU_PTR(__p, smp_processor_id())
> > +#define __THIS_CPU(__p) CPU_PTR(__p, raw_smp_processor_id())
> > +
> > +/*
> > + * Raw calls
> > + */
> > +void *cpu_alloc(unsigned long size, gfp_t gfp, unsigned long align);
> > +void cpu_free(void *cpu_pointer, unsigned long size);
> > +
> > +#endif /* _LINUX_CPU_ALLOC_H_ */
>
> Like said in the previous mail (which due to creative mailing from your
> end never made it out to the lists), I dislike those shouting macros.
> Please lowercase them.
sed -i -e 's/CPU_OFFSET/cpu_offset/g' -e 's/CPU_PTR/cpu_ptr/' -e
's/CPU_ALLOC/cpu_alloc_type/g' -e 's/cpu_free/__cpu_free/g' -e
's/CPU_FREE/cpu_free/' -e 's/THIS_CPU/this_cpu/g' patches/*.patch
should get you there.
next prev parent reply other threads:[~2007-11-08 12:37 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 19:51 [patch 00/28] cpu alloc v1: Optimize by removing arrays of pointers to per cpu objects Christoph Lameter
2007-11-06 19:51 ` [patch 01/28] cpu alloc: The allocator Christoph Lameter
2007-11-08 12:34 ` Peter Zijlstra
2007-11-08 12:37 ` Peter Zijlstra [this message]
2007-11-08 18:33 ` Christoph Lameter
2007-11-08 18:50 ` Christoph Lameter
2007-11-08 20:19 ` Peter Zijlstra
[not found] ` <1194522615.6289.136.camel@twins>
[not found] ` <Pine.LNX.4.64.0711081030380.7871@schroedinger.engr.sgi.com>
2007-11-08 20:19 ` Peter Zijlstra
2007-11-08 20:24 ` Christoph Lameter
2007-11-08 23:26 ` David Miller
2007-11-08 23:26 ` David Miller
2007-11-13 11:15 ` David Miller
2007-11-13 21:40 ` Christoph Lameter
2007-11-13 21:58 ` Eric Dumazet
2007-11-13 22:00 ` Christoph Lameter
2007-11-14 1:33 ` David Miller
2007-11-13 22:02 ` Christoph Lameter
2007-11-14 1:30 ` David Miller
2007-11-14 1:48 ` Christoph Lameter
2007-11-13 22:20 ` Christoph Lameter
2007-11-14 1:36 ` David Miller
2007-11-14 1:37 ` David Miller
2007-11-14 1:50 ` Christoph Lameter
2007-11-14 2:00 ` David Miller
2007-11-14 2:05 ` Christoph Lameter
2007-11-14 1:06 ` Andi Kleen
2007-11-14 1:52 ` David Miller
2007-11-14 1:57 ` Christoph Lameter
2007-11-14 2:01 ` David Miller
2007-11-14 2:03 ` Christoph Lameter
2007-11-14 2:28 ` Andi Kleen
2007-11-14 3:48 ` David Miller
2007-11-14 3:49 ` Christoph Lameter
2007-11-16 10:23 ` large lockdep bss (was: Re: [patch 01/28] cpu alloc: The allocator) Peter Zijlstra
2007-11-16 11:44 ` Andi Kleen
2007-11-14 4:15 ` [patch 01/28] cpu alloc: The allocator Christoph Lameter
2007-11-14 4:18 ` David Miller
2007-11-14 4:21 ` David Miller
2007-11-14 4:26 ` Christoph Lameter
2007-11-14 5:53 ` David Miller
2007-11-15 18:49 ` Christoph Lameter
2007-11-15 22:03 ` David Miller
2007-11-16 2:19 ` Christoph Lameter
2007-11-16 2:50 ` David Miller
2007-11-16 2:55 ` Christoph Lameter
2007-11-16 2:58 ` David Miller
2007-11-16 3:10 ` Christoph Lameter
2007-11-16 3:17 ` David Miller
2007-11-16 3:19 ` Christoph Lameter
2007-11-06 19:51 ` [patch 02/28] cpu alloc: x86_64 support Christoph Lameter
2007-11-06 19:51 ` [patch 03/28] cpu alloc: IA64 support Christoph Lameter
2007-11-06 19:51 ` [patch 04/28] cpu alloc: i386 support Christoph Lameter
2007-11-06 19:51 ` [patch 05/28] cpu alloc: Use in SLUB Christoph Lameter
2007-11-06 19:51 ` [patch 06/28] cpu alloc: Remove SLUB fields Christoph Lameter
2007-11-06 19:51 ` [patch 07/28] cpu alloc: page allocator conversion Christoph Lameter
2007-11-06 19:51 ` [patch 08/28] cpu alloc: percpu_counter conversion Christoph Lameter
2007-11-06 19:51 ` [patch 09/28] cpu alloc: crash_notes conversion Christoph Lameter
2007-11-06 19:51 ` [patch 10/28] cpu alloc: workqueue conversion Christoph Lameter
2007-11-06 19:51 ` [patch 11/28] cpu alloc: ACPI cstate handling conversion Christoph Lameter
2007-11-06 19:51 ` [patch 12/28] cpu alloc: genhd statistics conversion Christoph Lameter
2007-11-06 19:51 ` [patch 13/28] cpu alloc: blktrace conversion Christoph Lameter
2007-11-06 19:51 ` [patch 14/28] cpu alloc: SRCU Christoph Lameter
2007-11-06 19:51 ` [patch 15/28] cpu alloc: XFS counters Christoph Lameter
2007-11-06 19:52 ` [patch 16/28] cpu alloc: NFS statistics Christoph Lameter
2007-11-06 19:52 ` [patch 17/28] cpu alloc: neigbour statistics Christoph Lameter
2007-11-06 19:52 ` [patch 18/28] cpu alloc: tcp statistics Christoph Lameter
2007-11-06 19:52 ` [patch 19/28] cpu alloc: convert scatches Christoph Lameter
2007-11-06 19:52 ` [patch 20/28] cpu alloc: dmaengine conversion Christoph Lameter
2007-11-06 19:52 ` [patch 21/28] cpu alloc: convert loopback statistics Christoph Lameter
2007-11-06 19:52 ` [patch 22/28] cpu alloc: veth conversion Christoph Lameter
2007-11-06 19:52 ` [patch 23/28] cpu alloc: Chelsio statistics conversion Christoph Lameter
2007-11-06 19:52 ` [patch 24/28] cpu alloc: convert mib handling to cpu alloc Christoph Lameter
2007-11-06 19:52 ` [patch 25/28] cpu alloc: Explicitly code allocpercpu calls in iucv Christoph Lameter
2007-11-06 19:52 ` [patch 26/28] cpu alloc: Use for infiniband Christoph Lameter
2007-11-06 19:52 ` [patch 27/28] cpu alloc: Use in the crypto subsystem Christoph Lameter
2007-11-06 19:52 ` [patch 28/28] cpu alloc: Remove the allocpercpu functionality Christoph Lameter
2007-11-07 13:10 ` [patch 00/28] cpu alloc v1: Optimize by removing arrays of pointers to per cpu objects Martin Schwidefsky
2007-11-07 18:05 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194525459.6289.148.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox