public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Altenberg <jan.altenberg@linutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: miltonm@bga.com, linux-kernel@vger.kernel.org,
	linux-kbuild <linux-kbuild@vger.kernel.org>,
	tglx@linutronix.de
Subject: Re: kbuild: possible regression?
Date: Thu, 08 Nov 2007 20:45:01 +0100	[thread overview]
Message-ID: <1194551101.6014.156.camel@bender.lan> (raw)
In-Reply-To: <20071031094306.GB24100@uranus.ravnborg.org>

Hi Sam,

> > commit 0b35786d77ba4037f181982cc8ca20a7a3bf0fd2
> > Author: Milton Miller <miltonm@bga.com>
> > Date:   Fri Sep 21 18:09:02 2007 -0500
> > 
> >     kbuild: call make once for all targets when O=.. is used
> >     
> >     Change the invocations of make in the output directory Makefile and the
> >     main Makefile for separate object trees to pass all goals to one $(MAKE)
> >     via a new phony target "sub-make" and the existing target _all.
> >     
> >     When compiling with separate object directories, a separate make is called
> >     in the context of another directory (from the output directory the main
> >     Makefile is called, the Makefile is then restarted with current directory
> >     set to the object tree).  Before this patch, when multiple make command
> >     goals are specified, each target results in a separate make invocation.
> >     With make -j, these invocations may run in parallel, resulting in multiple
> >     commands running in the same directory clobbering each others results.
> >     
> >     I did not try to address make -j for mixed dot-config and no-dot-config
> >     targets.  Because the order does matter, a solution was not obvious.
> >     Perhaps a simple check for MAKEFLAGS having -j and refusing to run would
> >     be appropriate.
> >     
> >     Signed-off-by: Milton Miller <miltonm@bga.com>
> >     Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > 
> > So, am I facing a kbuild regression?
> 
> Yes - I will try to fix it during the weekend (if Milton does not beat me).
> Thanks for reporting and bisecting!

Have you made any progress on this? Let me know, if I can assist with
testing.

Cheers,
	Jan


  reply	other threads:[~2007-11-08 19:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31  9:03 kbuild: possible regression? Jan Altenberg
2007-10-31  9:43 ` Sam Ravnborg
2007-11-08 19:45   ` Jan Altenberg [this message]
2007-11-08 21:54     ` Sam Ravnborg
2007-12-06 20:59     ` Sam Ravnborg
2007-12-10  9:16       ` Jan Altenberg
2007-12-11 17:38         ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1194551101.6014.156.camel@bender.lan \
    --to=jan.altenberg@linutronix.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miltonm@bga.com \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox