Re: [PATCH 2/3] kvmclock - the host part.

Avi Kivity
2007-11-11T10:18:47Z

Glauber de Oliveira Costa wrote:
> This is the host part of kvm clocksource implementation. As it does
> not include clockevents, it is a fairly simple implementation. We
> only have to register a per-vcpu area, and start writting to it periodically.
>
>

Missing live migration support (a way for userspace to read and write
the guest clock address). Should probably be in a separate patch.

> @@ -1924,6 +1955,7 @@ out:
> goto preempted;
> }
>
> + kvm_write_guest_time(vcpu);
> post_kvm_run_save(vcpu, kvm_run);
>

Why here? Seems like we're leaving the guest for a while at this place.

Suggest putting it on top of __vcpu_run(), guarded by a flag, and
setting the flag every time we put the vcpu.

--
error compiling committee.c: too many arguments to function