Re: [PATCH 24/24] make vsmp a paravirt client

Jeremy Fitzhardinge
2007-11-13T17:23:50Z

Glauber de Oliveira Costa wrote:
> the ifdef only exists because, as I said, the code itself will be always
> compiled in, to avoid an ifdef in setup_64.c. So it's just a taking it
> from here, putting it there issue. Kiran seem to prefer this way, but I
> don't really have a preference.

It would be better to have the ifdef in setup_64.c and just make the
compilation of vsmp_64.c depend on CONFIG_X86_VSMP. If the ifdef really
rankles you could use a weak stub function somewhere, or define an
inline stub in vsmp.h.

J