From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
tony@bakeyournoodle.com, paulus@samba.org, dino@in.ibm.com,
tytso@us.ibm.com, dvhltc@us.ibm.com, niv@us.ibm.com,
antonb@us.ibm.com
Subject: Re: [PATCH, RFC] improved hacks to allow -rt to run kernbench on POWER
Date: Mon, 12 Nov 2007 07:48:45 +1100 [thread overview]
Message-ID: <1194814125.6510.14.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.58.0711110943510.12853@gandalf.stny.rr.com>
On Sun, 2007-11-11 at 09:45 -0500, Steven Rostedt wrote:
> > Well, I suppose the patch could go in, maybe with some ifdef's
> around
> > the bits in _switch_to, there's little point in doing that on non-rt
> > kernels.
>
> As Nick Piggin already stated, and I'll even state it for the RT
> kernel,
> we do not allow preemption in switch_to. So it is safe to remove those
> "preempt_disable" bits from the patch
Sure, I know that, I'm not talking about that, I'm talking about the
added code that flush pending batches & save the batch state, since on
non-rt kernel, this is not useful (the batch is only ever active within
a spinlocked section, which cannot be preempted on non-rt).
Ben.
next prev parent reply other threads:[~2007-11-11 20:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 18:10 [PATCH, RFC] improved hacks to allow -rt to run kernbench on POWER Paul E. McKenney
2007-11-09 20:52 ` Benjamin Herrenschmidt
2007-11-09 22:07 ` Paul E. McKenney
2007-11-11 3:59 ` Benjamin Herrenschmidt
2007-11-11 14:45 ` Steven Rostedt
2007-11-11 20:48 ` Benjamin Herrenschmidt [this message]
2007-11-12 17:05 ` Paul E. McKenney
2007-11-12 19:15 ` Paul E. McKenney
2007-11-12 21:12 ` Benjamin Herrenschmidt
2007-11-13 9:10 ` Peter Zijlstra
2007-11-13 9:43 ` Benjamin Herrenschmidt
2007-11-13 10:05 ` Peter Zijlstra
2007-11-13 10:59 ` Peter Zijlstra
2007-11-13 11:09 ` Benjamin Herrenschmidt
2007-11-10 1:18 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194814125.6510.14.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=antonb@us.ibm.com \
--cc=dino@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tony@bakeyournoodle.com \
--cc=tytso@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox