public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Glauber <jang@linux.vnet.ibm.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Pavel Emelyanov <xemul@openvz.org>,
	Andi Kleen <andi@firstfloor.org>,
	Jon Masters <jonathan@jonmasters.org>
Subject: [PATCH] module loader should not complain about unknown symbol
Date: Mon, 12 Nov 2007 14:18:27 +0000	[thread overview]
Message-ID: <1194877107.5656.31.camel@localhost.localdomain> (raw)

If module A depends on module B and module B has not yet finished its
init() the module loader may print a warning about an unknown symbol.

This happens if module B is still in state MODULE_STATE_COMING,
as module A runs into resolve_symbol() for a symbol from module B.
resolve_symbol() return 0 in that case and causes the warning.

---
Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com>

Index: linux-2.6/kernel/module.c
===================================================================
--- linux-2.6.orig/kernel/module.c	2007-11-12 13:53:44.000000000 +0000
+++ linux-2.6/kernel/module.c	2007-11-12 13:54:33.000000000 +0000
@@ -1411,8 +1411,8 @@
 			if (ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
 				break;
 
-			printk(KERN_WARNING "%s: Unknown symbol %s\n",
-			       mod->name, strtab + sym[i].st_name);
+			DEBUGP("%s: Unknown symbol %s\n", mod->name,
+			       strtab + sym[i].st_name);
 			ret = -ENOENT;
 			break;


             reply	other threads:[~2007-11-12 13:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12 14:18 Jan Glauber [this message]
2007-11-12 16:59 ` [PATCH] module loader should not complain about unknown symbol Andi Kleen
2007-11-12 22:23 ` Rusty Russell
2007-11-13  2:52   ` Rusty Russell
2007-11-13  4:08     ` Peter Teoh
2007-11-13  4:40       ` Rusty Russell
2007-11-13  4:55         ` Jon Masters
2007-11-14 12:12     ` Jan Glauber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1194877107.5656.31.camel@localhost.localdomain \
    --to=jang@linux.vnet.ibm.com \
    --cc=andi@firstfloor.org \
    --cc=jonathan@jonmasters.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox