Re: [patch 3/3] arch_rebalance_pgtables call

Benjamin Herrenschmidt
2007-11-14T22:08:31Z

On Wed, 2007-11-14 at 12:49 +0100, Martin Schwidefsky wrote:
>
> They all either have an arch override, call get_unmapped_area again or
> are not relevant. So it should be possible to do the upgrade in
> arch_get_unmapped_area. I still have my doubts though, all future uses
> of the get_unmapped_area pointer have to be checked and I feel it is
> easier to understand to do the upgrade / rebalance of the page table
> at
> the end of get_unmapped_area where every caller of mmap is guaranteed
> to
> pass through.

Well, if something does what you are worried about, then it would be
broken on powerpc as well (among others). We have various constraints on
the address space layout that must be handled by our arch g_u_a (or our
hugetlb one).

Ben.