From: Dave Hansen <haveblue@us.ibm.com>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mbligh@google.com
Subject: Re: [RFC 5/7] LTTng instrumentation mm
Date: Mon, 19 Nov 2007 11:43:01 -0800 [thread overview]
Message-ID: <1195501381.27759.127.camel@localhost> (raw)
In-Reply-To: <20071119185258.GA998@Krystal>
On Mon, 2007-11-19 at 13:52 -0500, Mathieu Desnoyers wrote:
> > > So I guess the result is a pointer ? Should this be expected ?
> >
> > Nope. 'pointer - pointer' is an integer. Just solve this equation for
> > integer:
> >
> > 'pointer + integer = pointer'
> >
>
> Well, using page_to_pfn turns out to be ugly in markers (and in
> printks) then. Depending on the architecture, it will result in either
> an unsigned long (x86_64) or an unsigned int (i386), which corresponds
> to %lu or %u and will print a warning if we don't cast it explicitly.
Casting the i386 one to be an unconditional 'unsigned long' shouldn't be
an issue. We don't generally expect pfns to fit into ints anyway.
-- Dave
next prev parent reply other threads:[~2007-11-19 19:43 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 19:33 [RFC 0/7] LTTng Kernel Instrumentation (Architecture Independent) Mathieu Desnoyers
2007-11-13 19:33 ` [RFC 1/7] Include marker.h in kernel.h -- temporary, for code readability Mathieu Desnoyers
2007-11-13 19:33 ` [RFC 2/7] LTTng instrumentation fs Mathieu Desnoyers
2007-11-13 19:33 ` [RFC 3/7] LTTng instrumentation ipc Mathieu Desnoyers
2007-11-13 19:33 ` [RFC 4/7] LTTng instrumentation kernel Mathieu Desnoyers
2007-11-15 23:30 ` Mike Mason
2007-11-15 23:54 ` Mike Mason
2007-11-16 2:42 ` Mathieu Desnoyers
2007-11-16 2:22 ` Mathieu Desnoyers
2007-11-13 19:33 ` [RFC 5/7] LTTng instrumentation mm Mathieu Desnoyers
2007-11-15 21:06 ` Dave Hansen
2007-11-15 21:51 ` Mathieu Desnoyers
2007-11-15 22:16 ` Dave Hansen
2007-11-16 14:30 ` Mathieu Desnoyers
2007-11-19 18:04 ` Dave Hansen
2007-11-28 14:09 ` [RFC PATCH] LTTng instrumentation mm (using page_to_pfn) Mathieu Desnoyers
2007-11-28 16:54 ` Dave Hansen
2007-11-29 2:34 ` Mathieu Desnoyers
2007-11-29 6:25 ` Dave Hansen
2007-11-30 16:11 ` [RFC PATCH] LTTng instrumentation mm (updated) Mathieu Desnoyers
2007-11-30 17:46 ` Dave Hansen
2007-11-30 17:05 ` Mathieu Desnoyers
2007-11-30 18:42 ` Dave Hansen
2007-11-30 19:10 ` Mathieu Desnoyers
2007-12-04 19:15 ` Frank Ch. Eigler
2007-12-04 19:25 ` Mathieu Desnoyers
2007-12-04 19:40 ` Dave Hansen
2007-12-04 20:05 ` Mathieu Desnoyers
2007-12-04 20:24 ` Dave Hansen
2007-12-04 20:28 ` Dave Hansen
2007-11-16 14:47 ` [RFC 5/7] LTTng instrumentation mm Mathieu Desnoyers
2007-11-19 18:07 ` Dave Hansen
2007-11-19 18:52 ` Mathieu Desnoyers
2007-11-19 19:00 ` Mathieu Desnoyers
2007-11-19 19:43 ` Dave Hansen
2007-11-19 19:43 ` Dave Hansen [this message]
2007-11-19 19:52 ` [PATCH] Cast __page_to_pfn to unsigned long in CONFIG_SPARSEMEM Mathieu Desnoyers
2007-11-19 20:09 ` Dave Hansen
2007-11-19 20:20 ` [PATCH] Cast page_to_pfn " Mathieu Desnoyers
2007-11-19 21:08 ` Andrew Morton
2007-11-19 21:19 ` Dave Hansen
2007-11-19 21:26 ` Dave Hansen
2007-11-21 20:12 ` Christoph Lameter
2007-11-20 17:34 ` Mathieu Desnoyers
2007-11-13 19:33 ` [RFC 6/7] LTTng instrumentation net Mathieu Desnoyers
2007-11-13 19:33 ` [RFC 7/7] Add Markers Into Semaphore Primitives Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195501381.27759.127.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox