From: ian <spyro@f2s.com>
To: eric miao <eric.y.miao@gmail.com>
Cc: Dmitry Baryshkov <dbaryshkov@gmail.com>,
ARM Linux <linux-arm-kernel@lists.arm.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices
Date: Wed, 21 Nov 2007 03:54:15 +0000 [thread overview]
Message-ID: <1195617255.2329.78.camel@wirenth> (raw)
In-Reply-To: <f17812d70711201823w6201bf88uf6268aaee3a32312@mail.gmail.com>
On Wed, 2007-11-21 at 10:23 +0800, eric miao wrote:
> Roughly went through the patch, looks good, here comes the remind, though :-)
>
> 1. is it possible to use some name other than "soc_core", maybe
> "tmio_core" so that other multifunction chips sharing a core base
> will live easier.
It's (soc-core) not tmio MFD specific - its already used by other MFD
chips (although obviously not ones in mainline (yet!)
it might be better named 'mfd-core' though, as thats its intended use...
> 2. those C++ style comments "//" are not so pleasant...
Should I clean them up and resubmit?
More to the point, who should I be submitting them to? the files under
arm/ are obviously for RMK to peruse, but I couldnt find an entry for
drivers/mfd in MAINTAINERS...
next prev parent reply other threads:[~2007-11-21 3:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 20:40 [patch] 0/4 Support for Toshiba TMIO multifunction devices ian
2007-11-20 22:04 ` Dmitry Baryshkov
2007-11-20 22:20 ` ian
2007-11-21 2:23 ` eric miao
2007-11-21 3:54 ` ian [this message]
2007-11-21 4:05 ` eric miao
2007-11-22 0:34 ` [UPDATED PATCH] " ian
2007-11-22 0:52 ` Russell King - ARM Linux
2007-11-22 10:52 ` ian
2007-11-26 12:23 ` Russell King - ARM Linux
2007-11-22 0:49 ` [patch] 0/4 " Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195617255.2329.78.camel@wirenth \
--to=spyro@f2s.com \
--cc=dbaryshkov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox