[PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()

[PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()

[Andre Haupt]

I think, the status paramter should be unsigned. Is this correct?
This also fixes a sparse warning about different signedness.
Only compile tested, because i do not have the hardware.

From: Andre Haupt <andre@bitwigglers.org>
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
---
 drivers/mmc/card/sdio_uart.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/card/sdio_uart.c b/drivers/mmc/card/sdio_uart.c
index d552de6..eeea84c 100644
--- a/drivers/mmc/card/sdio_uart.c
+++ b/drivers/mmc/card/sdio_uart.c
@@ -386,7 +386,7 @@ static void sdio_uart_stop_rx(struct sdio_uart_port *port)
 	sdio_out(port, UART_IER, port->ier);
 }
 
-static void sdio_uart_receive_chars(struct sdio_uart_port *port, int *status)
+static void sdio_uart_receive_chars(struct sdio_uart_port *port, unsigned int *status)
 {
 	struct tty_struct *tty = port->tty;
 	unsigned int ch, flag;
-- 
1.4.4.4

Re: [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()

[Pierre Ossman]

On Wed, 21 Nov 2007 12:33:45 +0100
Andre Haupt <andre@bitwigglers.org> wrote:

> I think, the status paramter should be unsigned. Is this correct?
> This also fixes a sparse warning about different signedness.
> Only compile tested, because i do not have the hardware.
> 
> From: Andre Haupt <andre@bitwigglers.org>
> Signed-off-by: Andre Haupt <andre@bitwigglers.org>

Nicolas, does this seem correct to you? I'm not familiar with the serial stuff.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

Re: [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()

[Nicolas Pitre]

On Sat, 24 Nov 2007, Pierre Ossman wrote:

> On Wed, 21 Nov 2007 12:33:45 +0100
> Andre Haupt <andre@bitwigglers.org> wrote:
> 
> > I think, the status paramter should be unsigned. Is this correct?
> > This also fixes a sparse warning about different signedness.
> > Only compile tested, because i do not have the hardware.
> > 
> > From: Andre Haupt <andre@bitwigglers.org>
> > Signed-off-by: Andre Haupt <andre@bitwigglers.org>
> 
> Nicolas, does this seem correct to you? I'm not familiar with the 
> serial stuff.

Yes, that should be fine.

Acked-by: Nicolas Pitre <nico@cam.org>


Nicolas