From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: Michael Buesch <mb@bu3sch.de>,
Roger Leigh <rleigh@whinlatter.ukfsn.org>,
linux-kernel@vger.kernel.org,
Dennis Munsie <dmunsie@cecropia.com>
Subject: Re: radeonfb i2c regression post-2.6.18.
Date: Sat, 24 Nov 2007 12:11:04 +1100 [thread overview]
Message-ID: <1195866664.7195.28.camel@pasglop> (raw)
In-Reply-To: <20071123232928.467378a7@hyperion.delvare>
On Fri, 2007-11-23 at 23:29 +0100, Jean Delvare wrote:
> On Fri, 23 Nov 2007 17:00:52 +0100, Michael Buesch wrote:
> > This patch fixes my crash problem.
>
> Out of curiosity, what kind of crash was it? I admit that I can't see
> how the code could crash.
Really sneaky... apparently, keeping the i2c lines asserted on his
laptop model would drain enough current through the pullups (or the
chip) that the temperature will raise significantly, causing a thermal
shutdown if the machine was already warm.
A bit scary... looks to me that a pullup is a bit too weak somewhere on
the motherboard.
That also means that this fix should reduce power consumption on the
battery significantly on those machines as it must take quite a bit of
power to increase the temperature that significantly (either that, or
the heating part sits just next to the sensor).
Cheers,
Ben.
next prev parent reply other threads:[~2007-11-24 1:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-18 23:16 radeonfb i2c regression post-2.6.18 Benjamin Herrenschmidt
2007-11-21 9:42 ` Roger Leigh
2007-11-21 19:58 ` Benjamin Herrenschmidt
2007-11-21 20:13 ` Michael Buesch
2007-11-21 20:17 ` Benjamin Herrenschmidt
2007-11-21 23:56 ` Roger Leigh
2007-11-22 0:00 ` Benjamin Herrenschmidt
2007-11-23 16:00 ` Michael Buesch
2007-11-23 22:29 ` Jean Delvare
2007-11-24 1:11 ` Benjamin Herrenschmidt [this message]
2007-11-24 9:29 ` Jean Delvare
2007-11-24 14:18 ` Michael Buesch
2007-11-24 22:20 ` Jean Delvare
2007-11-24 22:25 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2007-11-18 21:58 Roger Leigh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195866664.7195.28.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=dmunsie@cecropia.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=rleigh@whinlatter.ukfsn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox