public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Alexey Dobriyan <adobriyan@sw.ru>, linux-kernel@vger.kernel.org
Subject: Re: RFC - organize include/linux/kernel.h, add include/linux/logging.h
Date: Fri, 30 Nov 2007 11:20:53 -0800	[thread overview]
Message-ID: <1196450453.22120.199.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0711301908430.18767@fbirervta.pbzchgretzou.qr>

On Fri, 2007-11-30 at 19:09 +0100, Jan Engelhardt wrote:
> While you are at that, PFX should probably be KBUILD_MODNAME,
> for simplicity. Then it will be easy to consolidate since
> they all use KBUILD_MODNAME rather than their own PFX.
> Just btw :)

I think that nearly all private logging functions
could be eliminated by having a new macro defined
especially for logging.

Something akin to:

#define PRINTK_MODNAME  1
#define PRINTK_FILE     2
#define PRINTK_FUNCTION 4
#define PRINTK_LINE     8

#define PRINTK_PREFIX (your choice)
#include <linux/logging.h>

then all uses of pr_<level> could get modified for free.



  reply	other threads:[~2007-11-30 19:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30  9:28 RFC - organize include/linux/kernel.h, add include/linux/logging.h Alexey Dobriyan
2007-11-30 18:04 ` Joe Perches
2007-11-30 18:09   ` Jan Engelhardt
2007-11-30 19:20     ` Joe Perches [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-11-30  3:31 Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196450453.22120.199.camel@localhost \
    --to=joe@perches.com \
    --cc=adobriyan@sw.ru \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox