public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: stable@kernel.org
Cc: linux-kernel@vger.kernel.org, kvm-devel@lists.sourceforge.net,
	Aurelien Jarno <aurelien@aurel32.net>,
	Avi Kivity <avi@qumranet.com>
Subject: [PATCH 02/10] KVM: x86 emulator: fix access registers for instructions with ModR/M byte and Mod = 3
Date: Sun,  2 Dec 2007 13:18:39 +0200	[thread overview]
Message-ID: <11965943274184-git-send-email-avi@qumranet.com> (raw)
In-Reply-To: <1196594327338-git-send-email-avi@qumranet.com>

From: Aurelien Jarno <aurelien@aurel32.net>

The patch belows changes the access type to register from memory for
instructions that are declared as SrcMem or DstMem, but have a
ModR/M byte with Mod = 3.

It fixes (at least) the lmsw and smsw instructions on an AMD64 CPU,
which are needed for FreeBSD.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Avi Kivity <avi@qumranet.com>
---
 drivers/kvm/x86_emulate.c |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c
index 804e86c..08cd4a3 100644
--- a/drivers/kvm/x86_emulate.c
+++ b/drivers/kvm/x86_emulate.c
@@ -773,6 +773,14 @@ done_prefixes:
 	case SrcMem:
 		src.bytes = (d & ByteOp) ? 1 : op_bytes;
 	      srcmem_common:
+		/*
+		 * For instructions with a ModR/M byte, switch to register
+		 * access if Mod = 3.
+		 */
+		if ((d & ModRM) && modrm_mod == 3) {
+			src.type = OP_REG;
+			break;
+		}
 		src.type = OP_MEM;
 		src.ptr = (unsigned long *)cr2;
 		if ((rc = ops->read_emulated((unsigned long)src.ptr,
@@ -839,6 +847,15 @@ done_prefixes:
 		dst.type = OP_MEM;
 		dst.ptr = (unsigned long *)cr2;
 		dst.bytes = (d & ByteOp) ? 1 : op_bytes;
+		dst.val = 0;
+		/*
+		 * For instructions with a ModR/M byte, switch to register
+		 * access if Mod = 3.
+		 */
+		if ((d & ModRM) && modrm_mod == 3) {
+			dst.type = OP_REG;
+			break;
+		}
 		if (d & BitOp) {
 			unsigned long mask = ~(dst.bytes * 8 - 1);
 
-- 
1.5.3


  parent reply	other threads:[~2007-12-02 11:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-02 11:18 [PATCH 00/10]: KVM updates for 2.6.23.9 (-stable) Avi Kivity
2007-12-02 11:18 ` [PATCH 01/10] KVM: x86 emulator: implement 'movnti mem, reg' Avi Kivity
2007-12-02 11:18 ` Avi Kivity [this message]
2007-12-02 11:18 ` [PATCH 03/10] KVM: x86 emulator: invd instruction Avi Kivity
2007-12-02 11:18 ` [PATCH 04/10] KVM: SVM: Intercept the 'invd' and 'wbinvd' instructions Avi Kivity
2007-12-02 11:18 ` [PATCH 05/10] KVM: x86 emulator: Use emulator_write_emulated and not emulator_write_std Avi Kivity
2007-12-02 11:18 ` [PATCH 06/10] KVM: Fix hang on uniprocessor Avi Kivity
2007-12-02 11:18 ` [PATCH 07/10] KVM: SVM: Fix FPU leak while emulating clts Avi Kivity
2007-12-02 11:18 ` [PATCH 08/10] KVM: Skip pio instruction when it is emulated, not executed Avi Kivity
2007-12-02 11:18 ` [PATCH 09/10] KVM: VMX: Force vm86 mode if setting flags during real mode Avi Kivity
2007-12-02 11:18 ` [PATCH 10/10] KVM: VMX: Reset mmu context when entering " Avi Kivity
2007-12-02 19:08 ` [stable] [PATCH 00/10]: KVM updates for 2.6.23.9 (-stable) Greg KH
2007-12-03  9:23   ` [kvm-devel] " Avi Kivity
2007-12-03 12:57     ` [stable] [kvm-devel] " Greg KH
2007-12-03 13:11       ` [kvm-devel] [stable] " Avi Kivity
2007-12-03 13:31         ` [stable] [kvm-devel] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11965943274184-git-send-email-avi@qumranet.com \
    --to=avi@qumranet.com \
    --cc=aurelien@aurel32.net \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox