From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: v4l-dvb-maintainer@linuxtv.org,
Richard Knutsson <ricknu-0@student.ltu.se>,
linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes
Date: Mon, 03 Dec 2007 09:52:08 -0200 [thread overview]
Message-ID: <1196682728.6027.47.camel@gaivota> (raw)
In-Reply-To: <200712022049.33601.hverkuil@xs4all.nl>
Em Dom, 2007-12-02 às 20:49 +0100, Hans Verkuil escreveu:
> On Sunday 02 December 2007 18:46, Richard Knutsson wrote:
> > Fix "warning: Using plain integer as NULL pointer".
>
> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
>
> > Remove a gcc-2.95 requirement.
>
> NACK! The main v4l-dvb repository that contains this driver can also be
> compiled on older systems. I'd like to keep the option that the driver
> can be compiled with an older gcc version, unless Mauro thinks
> otherwise. Other than the removal of one comment and one space there
> are no other benefits of this change, so I'd prefer to keep it.
>From my POV, I don't see any reason to remove the required space to keep
gcc-2.95 compatibility.
The required extra whitespace is a small CodingStyle violation, but may
help to use the same driver code for systems that still use gcc-2.95.
So, it seems valid to keep this whitespace. Besides that, it is properly
commented.
Cheers,
Mauro
prev parent reply other threads:[~2007-12-03 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 17:46 [PATCH 1/2] ivtv: Some general fixes Richard Knutsson
2007-12-02 17:47 ` [PATCH 2/2] ivtv: Remove a invalid shadow-variable Richard Knutsson
2007-12-02 19:43 ` [v4l-dvb-maintainer] " Hans Verkuil
2007-12-02 19:49 ` [v4l-dvb-maintainer] [PATCH 1/2] ivtv: Some general fixes Hans Verkuil
2007-12-02 22:06 ` Richard Knutsson
2007-12-03 11:52 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196682728.6027.47.camel@gaivota \
--to=mchehab@infradead.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox