From: Dave Hansen <haveblue@us.ibm.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_*
Date: Tue, 04 Dec 2007 10:20:15 -0800 [thread overview]
Message-ID: <1196792415.6073.8.camel@localhost> (raw)
In-Reply-To: <11967818313780-git-send-email-joerg.roedel@amd.com>
On Tue, 2007-12-04 at 16:23 +0100, Joerg Roedel wrote:
>
> -#define _PAGE_FILE 0x040 /* nonlinear file mapping, saved PTE;
> unset:swap */
> -#define _PAGE_GLOBAL 0x100 /* Global TLB entry */
> +#define _PAGE_PRESENT (_AC(1, UL)<<_PAGE_BIT_PRESENT)
> +#define _PAGE_RW (_AC(1, UL)<<_PAGE_BIT_RW)
> +#define _PAGE_USER (_AC(1, UL)<<_PAGE_BIT_USER)
> +#define _PAGE_PWT (_AC(1, UL)<<_PAGE_BIT_PWT)
> +#define _PAGE_PCD (_AC(1, UL)<<_PAGE_BIT_PCD)
> +#define _PAGE_ACCESSED (_AC(1, UL)<<_PAGE_BIT_ACCESSED)
> +#define _PAGE_DIRTY (_AC(1, UL)<<_PAGE_BIT_DIRTY)
> +/* 2MB page */
> +#define _PAGE_PSE (_AC(1, UL)<<_PAGE_BIT_PSE)
> +/* nonlinear file mapping, saved PTE; unset:swap */
> +#define _PAGE_FILE (_AC(1, UL)<<_PAGE_BIT_FILE)
> +/* Global TLB entry */
> +#define _PAGE_GLOBAL (_AC(1, UL)<<_PAGE_BIT_GLOBAL)
Since you're defining these as macros anyway now and doing it
repetitively, could you make them a wee bit prettier?
Say something like:
#define _PAGE_MASK(x) (_AC(1, UL)<<(x))
-- Dave
next prev parent reply other threads:[~2007-12-04 18:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 15:23 [PATCH 0/3] x86_64: some minor paging cleanups Joerg Roedel
2007-12-04 15:23 ` [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_* Joerg Roedel
2007-12-04 18:20 ` Dave Hansen [this message]
2007-12-04 15:23 ` [PATCH 2/3] x86_64: use __PAGE_KERNEL* instead of _KERNPG_TABLE for 2MB PTEs in memory initialization Joerg Roedel
2007-12-04 15:23 ` [PATCH 3/3] x86_64: use __PAGE_KERNEL_EXEC in ioremap_64.c Joerg Roedel
-- strict thread matches above, loose matches on Subject: below --
2007-12-02 13:21 [PATCH 0/3] x86_64: some minor paging cleanups Joerg Roedel
2007-12-02 13:21 ` [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_* Joerg Roedel
2007-12-04 12:36 ` Ingo Molnar
2007-12-04 12:38 ` Ingo Molnar
2007-12-04 15:06 ` Joerg Roedel
2007-12-04 21:07 ` Ingo Molnar
2007-12-05 10:52 ` Joerg Roedel
2007-12-05 11:27 ` Ingo Molnar
2007-12-05 11:42 ` Joerg Roedel
2007-12-05 12:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196792415.6073.8.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox