From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@suse.de>, Ralf Baechle <ralf@linux-mips.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Please revert: PCI: fix IDE legacy mode resources
Date: Thu, 06 Dec 2007 16:04:07 +1100 [thread overview]
Message-ID: <1196917447.7033.17.camel@pasglop> (raw)
In-Reply-To: <200712060434.lB64YUtc023934@po-mbox305.hop.2iij.net>
On Thu, 2007-12-06 at 13:34 +0900, Yoichi Yuasa wrote:
> > I don't understand how his fix can work on MIPS nor why the previous
> > code didn't, but I don't know how MIPS does its remapping tricks,
> > however it will definitely -not- work on powerpc (and will break a
> > couple of machines out there).
>
> MIPS pcibios_fixup_bus() converts RAW BAR values(including offset) to
> resource values. How does it fix up on powerpc?
Same thing. We expect resources to contain raw values before . What I
don't understand is thus why you are calling resource_to_bus on 0x1f0
which is -not- a resource value, but is already a BAR value...
Ben.
next prev parent reply other threads:[~2007-12-06 5:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200710122305.l9CN5tFI008240@hera.kernel.org>
2007-12-06 0:10 ` Please revert: PCI: fix IDE legacy mode resources Benjamin Herrenschmidt
2007-12-06 4:34 ` Yoichi Yuasa
2007-12-06 5:04 ` Benjamin Herrenschmidt [this message]
2007-12-06 5:58 ` Yoichi Yuasa
2007-12-06 6:24 ` Benjamin Herrenschmidt
2007-12-09 2:12 ` Ralf Baechle
2007-12-09 7:24 ` Benjamin Herrenschmidt
2007-12-09 9:49 ` Benjamin Herrenschmidt
2007-12-09 12:46 ` Bartlomiej Zolnierkiewicz
2007-12-09 13:39 ` Alan Cox
2007-12-09 20:11 ` Benjamin Herrenschmidt
2007-12-09 13:38 ` Alan Cox
2007-12-09 20:03 ` Benjamin Herrenschmidt
2007-12-09 22:23 ` Alan Cox
2007-12-09 22:47 ` Benjamin Herrenschmidt
2007-12-10 4:29 ` Benjamin Herrenschmidt
2007-12-10 11:20 ` Alan Cox
2007-12-10 13:40 ` Ralf Baechle
2007-12-10 15:01 ` Alan Cox
2007-12-10 15:47 ` Ralf Baechle
2007-12-10 20:43 ` Benjamin Herrenschmidt
2007-12-11 0:05 ` Ralf Baechle
2007-12-11 0:27 ` Benjamin Herrenschmidt
2007-12-11 12:13 ` Ralf Baechle
2007-12-10 20:39 ` Benjamin Herrenschmidt
2007-12-10 23:07 ` Alan Cox
2007-12-11 0:10 ` Benjamin Herrenschmidt
2007-12-10 13:38 ` Ralf Baechle
2007-12-10 13:26 ` Ralf Baechle
2007-12-06 12:32 ` Ralf Baechle
2007-12-06 15:24 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196917447.7033.17.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=torvalds@linux-foundation.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox