From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753733AbXLFKbl (ORCPT ); Thu, 6 Dec 2007 05:31:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751739AbXLFKbd (ORCPT ); Thu, 6 Dec 2007 05:31:33 -0500 Received: from viefep18-int.chello.at ([213.46.255.22]:40037 "EHLO viefep12-int.chello.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751270AbXLFKbc (ORCPT ); Thu, 6 Dec 2007 05:31:32 -0500 Subject: Re: suspend-related lockdep warning From: Peter Zijlstra To: "Rafael J. Wysocki" Cc: Andrew Morton , Ingo Molnar , Pavel Machek , linux-kernel@vger.kernel.org In-Reply-To: <200712060121.24837.rjw@sisk.pl> References: <20071128024355.5931c6ec.akpm@linux-foundation.org> <200712032334.27088.rjw@sisk.pl> <20071203174505.c5ea84c4.akpm@linux-foundation.org> <200712060121.24837.rjw@sisk.pl> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-SQUWWE/vUtIRbf628sxj" Date: Thu, 06 Dec 2007 11:31:28 +0100 Message-Id: <1196937088.6788.56.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-SQUWWE/vUtIRbf628sxj Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2007-12-06 at 01:21 +0100, Rafael J. Wysocki wrote: > On Tuesday, 4 of December 2007, Andrew Morton wrote: > > [ 34.455096] ipw2200: Failed to send WEP_KEY: Command timed out. > > [ 34.911876] Syncing filesystems ... done. > > [ 34.934526] Freezing user space processes ... WARNING: at kernel/loc= kdep.c:2662 check_flags() > > [ 34.934917] Pid: 1922, comm: dbus-daemon Not tainted 2.6.24-rc3-mm3 = #2 > > [ 34.935036] [] show_trace_log_lvl+0x12/0x25 > > [ 34.935142] [] show_trace+0xd/0x10 > > [ 34.935231] [] dump_stack+0x55/0x5d > > [ 34.935322] [] check_flags+0x7f/0x11a > > [ 34.935417] [] lock_acquire+0x3a/0x86 > > [ 34.935511] [] _spin_lock+0x1c/0x49 > > [ 34.935603] [] refrigerator+0x13/0xc8 > > [ 34.935697] [] get_signal_to_deliver+0x34/0x2e8 > > [ 34.935807] [] do_notify_resume+0x8c/0x6fe > > [ 34.935907] [] work_notifysig+0x13/0x1b > > [ 34.936004] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > [ 34.936072] irq event stamp: 253 > > [ 34.936133] hardirqs last enabled at (253): [] syscall_ex= it_work+0x11/0x26 > > [ 34.936294] hardirqs last disabled at (252): [] syscall_ex= it+0x14/0x25 > > [ 34.936446] softirqs last enabled at (0): [] copy_process= +0x300/0x1246 > > [ 34.936599] softirqs last disabled at (0): [<00000000>] 0x0 > > [ 34.954308] (elapsed 0.01 seconds) done. > > [ 34.954389] Freezing remaining freezable tasks ... (elapsed 0.00 sec= onds) done. >=20 > Hmm, do I understand correctly that lockdep expects us to disable interru= pts > before acquiring the task lock in refrigerator()? That would be strange. >=20 > Ingo, can you have a look at this, please? No its complaining that the IRQ state changed without anybody telling it about it. Usually an unannotated cli/sti. The particular line it warns, (lockdep.c:2662), suggests...=20 /me grabs a copy of 24-rc3-mm2 ... that hardirqs are disabled, but irq tracking thinks they are still enabled. So that would be an unannotated cli. --=-SQUWWE/vUtIRbf628sxj Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD4DBQBHV8+AXA2jU0ANEf4RAtHnAJ9yBtIfVIywxhlwQkEIC9SYhcE8oACYm49T MBvK34FoEMwwojC5I5d05Q== =kBcr -----END PGP SIGNATURE----- --=-SQUWWE/vUtIRbf628sxj--