Re: [PATCH 19/19] unify set_tss_desc

Andi Kleen
2007-12-13T12:46:50Z

> +static inline void pack_tss(tss_desc *tss, unsigned long addr,
> + unsigned size, unsigned entry)
> +{
> +#ifdef CONFIG_X86_64
> + set_tssldt_descriptor(tss,
> + addr, entry, size);
> +#else
> + pack_descriptor(tss, (unsigned long)addr,
> + size,
> + 0x80 | entry, 0);

It would be better if you just unified that first instead of ifdef'ing.
I guess i386 could get a set_tssldt_descriptor() like wrapper
around pack_descriptor().

-Andi