From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Shane <gnome42@gmail.com>
Cc: Adrian Bunk <bunk@stusta.de>, Adrian Bunk <bunk@kernel.org>,
Brandon Philips <brandon@ifup.org>,
linux-kernel@vger.kernel.org,
video4linux-list <video4linux-list@redhat.com>
Subject: Re: [2.6 patch] videobuf-core.c locking fixes
Date: Thu, 13 Dec 2007 07:59:13 -0200 [thread overview]
Message-ID: <1197539953.4729.19.camel@gaivota> (raw)
In-Reply-To: <fa4052ef0712121235x54e1837cs2efe4ce5c6e0e84d@mail.gmail.com>
> > e1f8b4a49d86746f699919531c17fd154787e308
> > diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c
> > index 81f77d2..c8a5cb5 100644
> > --- a/drivers/media/video/videobuf-core.c
> > +++ b/drivers/media/video/videobuf-core.c
> > @@ -909,7 +909,7 @@ ssize_t videobuf_read_stream(struct videobuf_queue *q,
> > if (q->streaming)
> > goto done;
> > if (!q->reading) {
> > - retval = videobuf_read_start(q);
> > + retval = __videobuf_read_start(q);
> > if (retval < 0)
> > goto done;
> > }
> > @@ -982,7 +982,7 @@ unsigned int videobuf_poll_stream(struct file *file,
> > struct videobuf_buffer, stream);
> > } else {
> > if (!q->reading)
> > - videobuf_read_start(q);
> > + __videobuf_read_start(q);
> > if (!q->reading) {
> > rc = POLLERR;
> > } else if (NULL == q->read_buf) {
> >
>
> Yes it does! I was just going to send the same patch myself :)
The patch seems ok to my eyes. I dunno why I forgot to replace those two occurrences on my patch :(
Cheers,
Mauro
next prev parent reply other threads:[~2007-12-13 9:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 5:20 2.6.24-rc5 "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined! Shane
2007-12-12 9:07 ` Adrian Bunk
2007-12-12 11:03 ` Mauro Carvalho Chehab
2007-12-12 12:03 ` Adrian Bunk
2007-12-12 14:21 ` Mauro Carvalho Chehab
2007-12-12 16:37 ` Shane
2007-12-12 18:57 ` Shane
2007-12-12 19:44 ` [2.6 patch] videobuf-core.c locking fixes Adrian Bunk
2007-12-12 20:35 ` Shane
2007-12-12 21:22 ` Shane
2007-12-14 9:26 ` Mauro Carvalho Chehab
2007-12-13 9:59 ` Mauro Carvalho Chehab [this message]
2007-12-12 22:19 ` 2.6.24-rc5 "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined! Jean Delvare
2007-12-13 10:33 ` Mauro Carvalho Chehab
2007-12-12 10:36 ` Soeren Sonnenburg
2007-12-12 10:51 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197539953.4729.19.camel@gaivota \
--to=mchehab@infradead.org \
--cc=brandon@ifup.org \
--cc=bunk@kernel.org \
--cc=bunk@stusta.de \
--cc=gnome42@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox