From: Harvey Harrison <harvey.harrison@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 2/4] x86: fix asm memory constraints in local_64.h
Date: Sun, 16 Dec 2007 04:03:01 -0800 [thread overview]
Message-ID: <1197806581.3749.40.camel@brick> (raw)
Use the shorter +m form rather than =m and m.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
include/asm-x86/local_64.h | 30 ++++++++++++++----------------
1 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/include/asm-x86/local_64.h b/include/asm-x86/local_64.h
index da61076..7808f53 100644
--- a/include/asm-x86/local_64.h
+++ b/include/asm-x86/local_64.h
@@ -5,32 +5,30 @@ static inline void local_inc(local_t *l)
{
__asm__ __volatile__(
"incq %0"
- :"=m" (l->a.counter)
- :"m" (l->a.counter));
+ :"+m" (l->a.counter));
}
static inline void local_dec(local_t *l)
{
__asm__ __volatile__(
"decq %0"
- :"=m" (l->a.counter)
- :"m" (l->a.counter));
+ :"+m" (l->a.counter));
}
static inline void local_add(long i, local_t *l)
{
__asm__ __volatile__(
"addq %1,%0"
- :"=m" (l->a.counter)
- :"ir" (i), "m" (l->a.counter));
+ :"+m" (l->a.counter)
+ :"ir" (i));
}
static inline void local_sub(long i, local_t *l)
{
__asm__ __volatile__(
"subq %1,%0"
- :"=m" (l->a.counter)
- :"ir" (i), "m" (l->a.counter));
+ :"+m" (l->a.counter)
+ :"ir" (i));
}
/**
@@ -48,8 +46,8 @@ static inline int local_sub_and_test(long i, local_t *l)
__asm__ __volatile__(
"subq %2,%0; sete %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"ir" (i), "m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ :"ir" (i) : "memory");
return c;
}
@@ -67,8 +65,8 @@ static inline int local_dec_and_test(local_t *l)
__asm__ __volatile__(
"decq %0; sete %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ : : "memory");
return c != 0;
}
@@ -86,8 +84,8 @@ static inline int local_inc_and_test(local_t *l)
__asm__ __volatile__(
"incq %0; sete %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ : : "memory");
return c != 0;
}
@@ -106,8 +104,8 @@ static inline int local_add_negative(long i, local_t *l)
__asm__ __volatile__(
"addq %2,%0; sets %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"ir" (i), "m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ :"ir" (i) : "memory");
return c;
}
--
1.5.4.rc0.1083.gf568
next reply other threads:[~2007-12-16 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 12:03 Harvey Harrison [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-17 0:54 [PATCH 2/4] x86: fix asm memory constraints in local_64.h Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197806581.3749.40.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox