* [PATCH 5/4] x86: local.h fix checkpatch warnings
@ 2007-12-17 1:57 Harvey Harrison
2007-12-17 15:03 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2007-12-17 1:57 UTC (permalink / raw)
To: Ingo Molnar; +Cc: H. Peter Anvin, LKML, Thomas Gleixner
Mostly space after comma, one space after if.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
include/asm-x86/local.h | 17 ++++++++---------
1 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/include/asm-x86/local.h b/include/asm-x86/local.h
index f5677e2..f852c62 100644
--- a/include/asm-x86/local.h
+++ b/include/asm-x86/local.h
@@ -7,15 +7,14 @@
#include <asm/atomic.h>
#include <asm/asm.h>
-typedef struct
-{
+typedef struct {
atomic_long_t a;
} local_t;
#define LOCAL_INIT(i) { ATOMIC_LONG_INIT(i) }
#define local_read(l) atomic_long_read(&(l)->a)
-#define local_set(l,i) atomic_long_set(&(l)->a, (i))
+#define local_set(l, i) atomic_long_set(&(l)->a, (i))
static inline void local_inc(local_t *l)
{
@@ -137,7 +136,7 @@ static inline long local_add_return(long i, local_t *l)
long __i;
#ifdef CONFIG_M386
unsigned long flags;
- if(unlikely(boot_cpu_data.x86 <= 3))
+ if (unlikely(boot_cpu_data.x86 <= 3))
goto no_xadd;
#endif
/* Modern 486+ processor */
@@ -160,11 +159,11 @@ no_xadd: /* Legacy 386 processor */
static inline long local_sub_return(long i, local_t *l)
{
- return local_add_return(-i,l);
+ return local_add_return(-i, l);
}
-#define local_inc_return(l) (local_add_return(1,l))
-#define local_dec_return(l) (local_sub_return(1,l))
+#define local_inc_return(l) (local_add_return(1, l))
+#define local_dec_return(l) (local_sub_return(1, l))
#define local_cmpxchg(l, o, n) \
(cmpxchg_local(&((l)->a.counter), (o), (n)))
@@ -202,8 +201,8 @@ static inline long local_sub_return(long i, local_t *l)
*/
#define __local_inc(l) local_inc(l)
#define __local_dec(l) local_dec(l)
-#define __local_add(i,l) local_add((i),(l))
-#define __local_sub(i,l) local_sub((i),(l))
+#define __local_add(i, l) local_add((i), (l))
+#define __local_sub(i, l) local_sub((i), (l))
/* Use these for per-cpu local_t variables: on some archs they are
* much more efficient than these naive implementations. Note they take
--
1.5.4.rc0.1083.gf568
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5/4] x86: local.h fix checkpatch warnings
2007-12-17 1:57 [PATCH 5/4] x86: local.h fix checkpatch warnings Harvey Harrison
@ 2007-12-17 15:03 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2007-12-17 15:03 UTC (permalink / raw)
To: Harvey Harrison; +Cc: H. Peter Anvin, LKML, Thomas Gleixner
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Mostly space after comma, one space after if.
thanks Harvey, i've applied all your local.h unification patches to
x86.git. They successfully passed a couple of build and boot tests as
well.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-17 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-17 1:57 [PATCH 5/4] x86: local.h fix checkpatch warnings Harvey Harrison
2007-12-17 15:03 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox