Re: [PATCH] max3100 driver

Ben Pfaff
2008-09-21T16:06:21Z

Arjan van de Ven <arjan@infradead.org> writes:

> I do have a question though: what does a signed bitfield of 1 mean?
> I mean.. the variables are "int", so signed.... where will the compiler
> store the sign bit???

Whether a bit-field declared as type "int" is signed or unsigned
is compiler implementation-defined. As C99 6.7.2 says (there is
similar text in C89):

...for bit-fields, it is implementation-defined whether the
specifier int designates the same type as signed int or the
same type as unsigned int.

Thus, it is never a good idea to declare a bit-field as plain
"int". Declare it as "signed int" or "unsigned int" instead.
--
"Mon peu de succès près des femmes est toujours venu de les trop aimer."
--Jean-Jacques Rousseau