Re: [PATCH] drivers/net/: Spelling fixes

Re: [PATCH] drivers/net/: Spelling fixes

[Chris Snook]

Joe Perches wrote:
>  drivers/net/atl1/atl1_hw.c                     |    2 +-
>  drivers/net/atl1/atl1_main.c                   |    2 +-

The atl1 code will be heavily reworked in the 2.6.25 merge window, so this may 
cause headaches.  Please remove these chunks before merging.

The spelling corrections themselves are fine, and I will ensure that the revised 
driver includes them, if the comments in question are still present at all once 
we're done with all the changes and cleanups.

	-- Chris

Re: [PATCH] drivers/net/: Spelling fixes

[Pavel Roskin]

On Mon, 2007-12-17 at 11:40 -0800, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>

> diff --git a/drivers/net/wireless/orinoco.h
> b/drivers/net/wireless/orinoco.h
> index 4720fb2..703a4cf 100644
> --- a/drivers/net/wireless/orinoco.h
> +++ b/drivers/net/wireless/orinoco.h
> @@ -108,7 +108,7 @@ struct orinoco_private {
>  	int	scan_inprogress;	/* Scan pending... */
>  	u32	scan_mode;		/* Type of scan done */
>  	char *	scan_result;		/* Result of previous scan */
> -	int	scan_len;		/* Lenght of result */
> +	int	scan_len;		/* Length of result */
>  };
>  
>  #ifdef ORINOCO_DEBUG

Acked-by: Pavel Roskin <proski@gnu.org>

Actually, I don't think such minor comment fixes need to be reviewed by
the maintainers.  Thanks anyway.

-- 
Regards,
Pavel Roskin

Re: [PATCH] drivers/net/: Spelling fixes

[Joe Perches]

On Mon, 2007-12-17 at 15:40 -0500, Pavel Roskin wrote:
> On Mon, 2007-12-17 at 11:40 -0800, Joe Perches wrote:
> I don't think such minor comment fixes need to be reviewed by
> the maintainers.  Thanks anyway.

I'd like to know who pushes what source tree sections forward.

I have a script that uses annotated MAINTAINERS sections
to forward patches to "appropriate" maintainers.  That script
generated the CC's.

To me the question is who pushes.

If it's not a maintainer, who does?  Anyone have list?

Re: [PATCH] drivers/net/: Spelling fixes

[Joe Perches]

On Mon, 2007-12-17 at 21:56 +0100, Stefano Brivio wrote:
> On Mon, 17 Dec 2007 11:40:08 -0800
> Joe Perches <joe@perches.com> wrote:
> > diff --git a/drivers/net/ucc_geth_ethtool.c
> b/drivers/net/ucc_geth_ethtool.c
> > index 9a9622c..f8d319b 100644
> > --- a/drivers/net/ucc_geth_ethtool.c
> > +++ b/drivers/net/ucc_geth_ethtool.c
> > @@ -7,7 +7,7 @@
> >   *
> >   * Limitation: 
> >   * Can only get/set setttings of the first queue.
>                          ^^^

Good eyes...  Unrelated to what I changed too.
cheers, Joe

Signed-off-by: Joe Perches <joe@perches.com>
---
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index 121cb10..cdfb2b0 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -6823,8 +6823,8 @@ static void do_s2io_card_down(struct s2io_nic * sp, int do_io)
 	while(do_io) {
 		/* As per the HW requirement we need to replenish the
 		 * receive buffer to avoid the ring bump. Since there is
-		 * no intention of processing the Rx frame at this pointwe are
-		 * just settting the ownership bit of rxd in Each Rx
+		 * no intention of processing the Rx frame at this point we are
+		 * just setting the ownership bit of rxd in each Rx
 		 * ring to HW and set the appropriate buffer size
 		 * based on the ring mode
 		 */
diff --git a/drivers/net/ucc_geth_ethtool.c b/drivers/net/ucc_geth_ethtool.c
index f8d319b..3e50df8 100644
--- a/drivers/net/ucc_geth_ethtool.c
+++ b/drivers/net/ucc_geth_ethtool.c
@@ -6,7 +6,7 @@
  * Author: Li Yang <leoli@freescale.com>
  *
  * Limitation: 
- * Can only get/set setttings of the first queue.
+ * Can only get/set settings of the first queue.
  * Need to re-open the interface manually after changing some parameters.
  *
  * This program is free software; you can redistribute  it and/or modify it