Re: [PATCH 13/21] [PATCH] change bitwise operations to get a void parameter.

H. Peter Anvin
2007-12-18T05:44:15Z

Rusty Russell wrote:
> On Tuesday 18 December 2007 09:52:36 Glauber de Oliveira Costa wrote:
>> This patch changes the bitwise operations in bitops.h to get
>> a void pointers as a parameter. Before this patch, a lot of warnings
>> can be seen. They're gone after it.
>
> No, this is a backwards step! These warnings are important for
> non-arch-specific code: I fought hard to get them made into unsigned longs.
>
> But I'm happy for this to be applied as is, then I'll grab the git tree,
> revert it and fix the warnings...
>

Yes, it's particularly nasty as it'll work fine on littleendian arches,
and fail on bigendian arches...

-hpa