Re: [PATCH 21/21] [PATCH] finish processor.h integration

Ingo Molnar
2007-12-18T15:44:35Z

* Glauber de Oliveira Costa <gcosta@redhat.com> wrote:

>> here the problem is apparently caused by your patch, a careless
>> 'unification' of include file sections. 32-bit had this:
>
> Point is this patches do unification, but they are not just that, as
> you can see. I am attempting to cleanup headers that appears not to be
> used, [...]

do cleanups and unification in _separate_ patches. We do not want to
change a SINGLE LINE OF SOURCE CODE in a patch that says "unify" and
moves a block of code from one file to another, ok? If you see some
obvious cleanups do it in pre or post patches (whichever looks more
logical). That makes it totally bisectable and i can drop the bogus
cleanup patch instead of having to drop a full unification patch.

Ingo