From: "Huang, Ying" <ying.huang@intel.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Greg KH <greg@kroah.com>,
akpm@linux-foundation.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm -v3] x86 boot : export boot_params via sysfs
Date: Tue, 18 Dec 2007 15:29:34 +0800 [thread overview]
Message-ID: <1197962974.12999.29.camel@caritas-dev.intel.com> (raw)
In-Reply-To: <m1abo8d3jk.fsf@ebiederm.dsl.xmission.com>
On Mon, 2007-12-17 at 21:34 -0700, Eric W. Biederman wrote:
> "H. Peter Anvin" <hpa@zytor.com> writes:
>
> > This is directly analogous to how we treat identity information in IDE, or PCI
> > configuration space -- some fields are pre-digested, but the entire raw
> > information is also available.
>
> Add to that a totally unchanged value can just be easier to get correct.
>
> Still the kexec code as much as it can should not look there, as we may
> get the same basic information in a couple of different ways.
>
> EFI memmap vs. e820 for example. If/when that is the case /sbin/kexec
> should get the information and spit it out into whatever format makes
> sense for the destination kernel. My sense is just passing through
> values is brittleness where we don't want it.
>
> However I think being able to get at the raw boot information overall
> sounds useful. I just don't know if it is generally useful or just
> useful when debugging bootloaders though.
If struct boot_params as a whole is useless for kexec, I can move it to
debugfs, because kexec is the only normal user now. Then which fields of
struct boot_params do you think is useful for kexec?
Refer to include/asm-x86/bootparam.h
edid_info?
e820_entries and e820_map? maybe useful for kdump
edd related fields (eddbuf, edd_mbr_sig_buffer, etc)? split fields until fundamental types?
Best Regards,
Huang Ying
prev parent reply other threads:[~2007-12-18 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 8:16 [PATCH -mm -v3] x86 boot : export boot_params via sysfs Huang, Ying
2007-12-14 15:52 ` Greg KH
2007-12-14 18:12 ` H. Peter Anvin
2007-12-14 19:00 ` H. Peter Anvin
2007-12-18 4:34 ` Eric W. Biederman
2007-12-18 7:29 ` Huang, Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197962974.12999.29.camel@caritas-dev.intel.com \
--to=ying.huang@intel.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox