From: Dave Hansen <haveblue@us.ibm.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Hugh Dickins <hugh@veritas.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page
Date: Wed, 19 Dec 2007 09:14:33 -0800 [thread overview]
Message-ID: <1198084473.15321.48.camel@localhost> (raw)
In-Reply-To: <20071219061834.8461.3974.sendpatchset@balbir-laptop>
On Wed, 2007-12-19 at 11:48 +0530, Balbir Singh wrote:
> diff -puN mm/page_alloc.c~memory-controller-move-to-bug-on-in-free_hot_cold_page mm/page_alloc.c
> --- linux-2.6.24-rc5/mm/page_alloc.c~memory-controller-move-to-bug-on-in-free_hot_cold_page 2007-12-19 11:31:46.000000000 +0530
> +++ linux-2.6.24-rc5-balbir/mm/page_alloc.c 2007-12-19 11:33:45.000000000 +0530
> @@ -995,7 +995,7 @@ static void fastcall free_hot_cold_page(
>
> if (!PageHighMem(page))
> debug_check_no_locks_freed(page_address(page), PAGE_SIZE);
> - page_assign_page_cgroup(page, NULL);
> + VM_BUG_ON(page_get_page_cgroup(page));
> arch_free_page(page, 0);
> kernel_map_pages(page, 1, 0);
Hi Balbir,
You generally want to do these like:
foo = page_assign_page_cgroup(page, NULL);
VM_BUG_ON(foo);
Some embedded people have been known to optimize kernel size like this:
#define VM_BUG_ON(x) do{}while(0)
-- Dave
next prev parent reply other threads:[~2007-12-19 17:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 6:18 [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page Balbir Singh
2007-12-19 17:14 ` Dave Hansen [this message]
2007-12-20 13:14 ` Hugh Dickins
2007-12-20 13:51 ` Peter Zijlstra
2007-12-20 14:16 ` Hugh Dickins
2007-12-20 14:20 ` Peter Zijlstra
2007-12-20 16:24 ` Balbir Singh
2007-12-20 16:35 ` Dave Hansen
2007-12-20 17:12 ` Andrew Morton
2007-12-20 17:21 ` Hugh Dickins
2007-12-20 17:39 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198084473.15321.48.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).