From: Dave Hansen <haveblue@us.ibm.com>
To: balbir@linux.vnet.ibm.com
Cc: Peter Zijlstra <peterz@infradead.org>,
Hugh Dickins <hugh@veritas.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page
Date: Thu, 20 Dec 2007 08:35:31 -0800 [thread overview]
Message-ID: <1198168531.15321.63.camel@localhost> (raw)
In-Reply-To: <476A972F.6050904@linux.vnet.ibm.com>
On Thu, 2007-12-20 at 21:54 +0530, Balbir Singh wrote:
>
> I was going to say the same thing, page_get_page_cgroup() does not hold
> any references. May be _get_ in the name is confusing.
OK, you three had the entire conversation outing me before I even fot to
respond! :)
Yeah, I thought it was a refcount acquisition. Balbir, it's fine the
way it stands (except for the slightly confusing name).
-- Dave
next prev parent reply other threads:[~2007-12-20 16:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 6:18 [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page Balbir Singh
2007-12-19 17:14 ` Dave Hansen
2007-12-20 13:14 ` Hugh Dickins
2007-12-20 13:51 ` Peter Zijlstra
2007-12-20 14:16 ` Hugh Dickins
2007-12-20 14:20 ` Peter Zijlstra
2007-12-20 16:24 ` Balbir Singh
2007-12-20 16:35 ` Dave Hansen [this message]
2007-12-20 17:12 ` Andrew Morton
2007-12-20 17:21 ` Hugh Dickins
2007-12-20 17:39 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198168531.15321.63.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).