From: "Clemens Ladisch" <clemens@ladisch.de>
To: "Bernhard Walle" <bwalle@suse.de>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de
Subject: Re: [PATCH] Fix RTC_AIE with CONFIG_HPET_EMULATE_RTC
Date: Sun, 23 Dec 2007 19:15:11 +0100 [thread overview]
Message-ID: <1198433711.31341.1228016275@webmail.messagingengine.com> (raw)
In-Reply-To: <20071220144009.GA29859@suse.de>
Bernhard Walle wrote:
> In the current code, RTC_AIE doesn't work if the RTC relies on
> CONFIG_HPET_EMULATE_RTC because the code sets the RTC_AIE flag
> in hpet_set_rtc_irq_bit(). The interrupt handles does accidentally
> check for RTC_PIE and not RTC_AIE when comparing the time
> which was set in hpet_set_alarm_time().
>
> This patch is against 2.6.24-rc5-mm1.
>
>
> Signed-off-by: Bernhard Walle <bwalle@suse.de>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> arch/x86/kernel/hpet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/kernel/hpet.c
> +++ b/arch/x86/kernel/hpet.c
> @@ -657,7 +657,7 @@ irqreturn_t hpet_rtc_interrupt(int irq,
> hpet_pie_count = 0;
> }
>
> - if (hpet_rtc_flags & RTC_PIE &&
> + if (hpet_rtc_flags & RTC_AIE &&
> (curr_time.tm_sec == hpet_alarm_time.tm_sec) &&
> (curr_time.tm_min == hpet_alarm_time.tm_min) &&
> (curr_time.tm_hour == hpet_alarm_time.tm_hour))
prev parent reply other threads:[~2007-12-23 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-20 14:40 [PATCH] Fix RTC_AIE with CONFIG_HPET_EMULATE_RTC Bernhard Walle
2007-12-23 18:15 ` Clemens Ladisch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198433711.31341.1228016275@webmail.messagingengine.com \
--to=clemens@ladisch.de \
--cc=akpm@linux-foundation.org \
--cc=bwalle@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox