From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Loic Prylli <loic@myri.com>, Robert Hancock <hancockr@shaw.ca>,
Jeff Garzik <jeff@garzik.org>,
Arjan van de Ven <arjan@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
gregkh@suse.de, linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>,
Martin Mares <mj@ucw.cz>, Matthew Wilcox <matthew@wil.cx>,
Kai Ruhnau <kai@tragetaschen.dyndns.org>
Subject: Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in
Date: Fri, 28 Dec 2007 16:29:50 +1100 [thread overview]
Message-ID: <1198819790.7209.27.camel@pasglop> (raw)
In-Reply-To: <alpine.LFD.0.9999.0712271328010.21557@woody.linux-foundation.org>
On Thu, 2007-12-27 at 13:37 -0800, Linus Torvalds wrote:
> The code doesn't actually do what CRS is supposed to help with (ie go
> on
> to probe another device and then come back to the slow one later), so
> right now it's pretty much useless *anyway*.
It's not totally useless... Instead of not seeing the device that hasn't
fully initialized yet at all, we end up waiting a bit and then seeing
it. Going to probe somebody else is a nice optimization we could do with
multithread PCI probe but doesn't remove the need for CRS.
I have embedded boards where proper CRS operations is critical since the
kernel brings the PCIe link up itself, and thus is likely to hit devices
still in the middle of CRS.
Note that I'm -very- surprised however that your BIOS hands control out
of the kernel with devices still issuing CRS... Unless those devices may
do it after boot but that's dodgy and will break many other things.
Ben.
next prev parent reply other threads:[~2007-12-28 5:30 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.m7tRTz/ymu3iMyLTO2aF1Tvaw24@ifi.uio.no>
[not found] ` <fa.XrRLIuL4juNAXXaMPF3iY8FyWW8@ifi.uio.no>
[not found] ` <fa.gv3MUHxQvd7EaG/0hhC9IzBvIlA@ifi.uio.no>
2007-12-27 17:59 ` [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in Robert Hancock
2007-12-27 19:47 ` Arjan van de Ven
[not found] ` <fa.H0fcNl3b6xVBwzWUgT72M4K6KOU@ifi.uio.no>
2007-12-27 18:15 ` Robert Hancock
2007-12-27 18:30 ` Kai Ruhnau
2007-12-27 18:58 ` Linus Torvalds
2007-12-27 21:10 ` Loic Prylli
2007-12-27 21:21 ` Matthew Wilcox
2007-12-27 21:37 ` Linus Torvalds
2007-12-27 21:46 ` Linus Torvalds
2007-12-27 22:18 ` Kai Ruhnau
2007-12-28 4:27 ` Daniel Barkalow
2007-12-28 5:32 ` Linus Torvalds
2007-12-28 6:07 ` Daniel Barkalow
2007-12-28 10:34 ` Ivan Kokshaysky
2007-12-28 16:14 ` Arjan van de Ven
2007-12-28 16:38 ` Ivan Kokshaysky
2007-12-28 17:40 ` Loic Prylli
2007-12-28 21:12 ` Ivan Kokshaysky
2008-01-13 6:01 ` Matthew Wilcox
2008-01-13 7:19 ` Loic Prylli
2007-12-28 5:31 ` Benjamin Herrenschmidt
2007-12-27 21:59 ` Kai Ruhnau
2007-12-28 5:27 ` Benjamin Herrenschmidt
2007-12-28 5:29 ` Benjamin Herrenschmidt [this message]
2007-12-28 5:37 ` Linus Torvalds
2007-12-28 6:06 ` Benjamin Herrenschmidt
2007-12-28 19:14 ` Loic Prylli
2007-12-28 20:42 ` Benjamin Herrenschmidt
2007-12-28 0:18 ` Robert Hancock
[not found] <fa.2KorSXroIUtdRjFJWJwy49QuIYk@ifi.uio.no>
[not found] ` <fa.KgDY4hzBogAL+o607R+LHzW+HTc@ifi.uio.no>
[not found] ` <fa.xzH/eH5b6vCHpOD31Cq2nyq6z/k@ifi.uio.no>
[not found] ` <fa.EPUIDYIoxtDNcRrL9p3fAkr80Lo@ifi.uio.no>
[not found] ` <fa.uPoC9dcdekzy7g8QYFyuwelukiQ@ifi.uio.no>
[not found] ` <fa.O9WUKjAu+MfGg712w8Y4HkQ7GIo@ifi.uio.no>
2008-01-13 1:56 ` Robert Hancock
[not found] ` <fa.y9bLGEm23C6rL/wz7kMpKYF67oM@ifi.uio.no>
[not found] ` <fa.S+otiE5kNySVMlhUagdf/n9GRIc@ifi.uio.no>
[not found] ` <fa.OH5C/OjPYJXn8kSOHV/09piVz0E@ifi.uio.no>
[not found] ` <fa.jj0GkdAagaR3CLapBSdT1psD3Ps@ifi.uio.no>
[not found] ` <fa.EgRiN/duILxBcenHk7dQyC+rldw@ifi.uio.no>
2008-01-14 23:59 ` Robert Hancock
2007-12-25 11:26 Arjan van de Ven
2007-12-27 11:52 ` Jeff Garzik
2007-12-27 14:09 ` Arjan van de Ven
2007-12-27 17:52 ` Linus Torvalds
2008-01-11 19:02 ` Greg KH
2008-01-11 19:09 ` Arjan van de Ven
2008-01-11 19:14 ` Greg KH
2008-01-11 19:28 ` Matthew Wilcox
2008-01-11 19:40 ` Arjan van de Ven
2008-01-11 19:45 ` Greg KH
2008-01-11 19:49 ` Matthew Wilcox
2008-01-11 19:58 ` Linus Torvalds
2008-01-11 20:17 ` Matthew Wilcox
2008-01-11 20:27 ` Linus Torvalds
2008-01-11 20:42 ` Matthew Wilcox
2008-01-11 21:12 ` Linus Torvalds
2008-01-11 21:17 ` Matthew Wilcox
2008-01-11 21:28 ` Linus Torvalds
2008-01-11 21:38 ` Matthew Wilcox
2008-01-11 23:58 ` Ivan Kokshaysky
2008-01-12 0:17 ` Jesse Barnes
2008-01-12 0:26 ` Greg KH
2008-01-12 14:40 ` Ivan Kokshaysky
2008-01-12 15:46 ` Arjan van de Ven
2008-01-12 16:23 ` Ivan Kokshaysky
2008-01-12 17:45 ` Arjan van de Ven
2008-01-12 18:17 ` Matthew Wilcox
2008-01-12 21:49 ` Ivan Kokshaysky
2008-01-12 23:01 ` Arjan van de Ven
2008-01-13 0:12 ` Tony Camuso
2008-01-13 0:40 ` Arjan van de Ven
2008-01-13 1:36 ` Tony Camuso
2008-01-13 4:42 ` Arjan van de Ven
2008-01-13 4:47 ` Matthew Wilcox
2008-01-13 6:43 ` Jeff Garzik
2008-01-13 12:43 ` Tony Camuso
2008-01-13 17:03 ` Arjan van de Ven
2008-01-13 21:28 ` Tony Camuso
2008-01-14 0:54 ` Alan Cox
2008-01-14 1:33 ` Arjan van de Ven
2008-01-14 3:29 ` Tony Camuso
2008-01-14 5:05 ` Arjan van de Ven
2008-01-14 13:01 ` Tony Camuso
2008-01-14 14:46 ` Arjan van de Ven
2008-01-14 15:23 ` Tony Camuso
2008-01-14 16:01 ` Arjan van de Ven
2008-01-14 16:08 ` Tony Camuso
2008-01-14 9:11 ` Alan Cox
2008-01-14 5:20 ` Linus Torvalds
2008-01-13 18:23 ` Loic Prylli
2008-01-13 18:41 ` Arjan van de Ven
2008-01-13 20:43 ` Matthew Wilcox
2008-01-13 21:18 ` Loic Prylli
2008-01-13 20:51 ` Loic Prylli
2008-01-13 7:08 ` Benjamin Herrenschmidt
2008-01-13 7:24 ` Matthew Wilcox
2008-01-13 7:58 ` Matthew Wilcox
2008-01-13 17:01 ` Arjan van de Ven
2008-01-14 22:52 ` Matthew Wilcox
2008-01-14 23:04 ` Adrian Bunk
2008-01-15 16:00 ` Loic Prylli
2008-01-15 17:46 ` Greg KH
2008-01-15 17:56 ` Matthew Wilcox
2008-01-15 19:27 ` Tony Camuso
2008-01-15 19:38 ` Linus Torvalds
2008-01-15 19:40 ` Matthew Wilcox
2008-01-15 22:12 ` Loic Prylli
2008-01-19 16:58 ` Grant Grundler
2008-01-28 18:32 ` Tony Camuso
2008-01-28 20:44 ` Greg KH
2008-01-28 22:31 ` Matthew Wilcox
2008-01-28 22:53 ` Greg KH
2008-01-29 2:56 ` Matthew Wilcox
2008-01-29 3:05 ` Arjan van de Ven
2008-01-29 3:18 ` Matthew Wilcox
2008-01-29 13:19 ` Greg KH
2008-01-29 14:15 ` Tony Camuso
2008-01-29 14:47 ` Arjan van de Ven
2008-01-29 15:15 ` Tony Camuso
2008-01-29 15:29 ` Arjan van de Ven
2008-01-29 16:26 ` Tony Camuso
2008-01-29 23:57 ` Matthew Wilcox
2008-01-30 2:30 ` Tony Camuso
2008-01-30 3:45 ` Matthew Wilcox
2008-01-30 15:15 ` Ivan Kokshaysky
2008-01-30 15:42 ` Arjan van de Ven
2008-01-30 20:14 ` Ivan Kokshaysky
2008-01-31 5:51 ` Jesse Barnes
2008-01-11 19:54 ` Arjan van de Ven
2008-01-11 20:55 ` Greg KH
2008-01-15 12:58 ` Øyvind Vågen Jægtnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1198819790.7209.27.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=arjan@infradead.org \
--cc=gregkh@suse.de \
--cc=hancockr@shaw.ca \
--cc=jeff@garzik.org \
--cc=kai@tragetaschen.dyndns.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=loic@myri.com \
--cc=matthew@wil.cx \
--cc=mj@ucw.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox