Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

Arjan van de Ven
2007-12-27T19:50:16Z

On Thu, 27 Dec 2007 11:59:23 -0600
Robert Hancock <hancockr@shaw.ca> wrote:

> Arjan van de Ven wrote:
> >> 2) [non-minor] hmmmm.
> >>
> >> [jgarzik@core ~]$ lspci -n | wc -l
> >> 23
> >>
> >> So I would have to perform 23 sysfs twiddles, before I could
> >> obtain a full and unabridged 'lspci -vvvxxx'?
> >
> > not you as human, but "lspci" ought to yes.
> >
> >> For the userspace interface, the most-often-used knob for
> >> diagnostic purposes will be the easiest one. And that's
> >
> > the easiest one is an option to lspci. Nothing more nothing less.
> >
> > Making a global knob in kernel space is a lot more tricky, and in
> > addition really there's enough cases where userspace wants the one
> > device anyway Doing the "for each device I'm about to dump" in
> > lspci is pretty much as hard as doing the global one (if not
> > simpler)
>
> So then if you have a system where MMCONFIG doesn't work and you're
> not using any devices that require extended config space, then doing
> lspci -vvvxxx will blow up the machine? Yuck.

ONLY in the case where you would have otherwise blown up at boot.
Lets face it; blowing up if the admin does "lspci -vvvxxx" with a clear
message in dmesg about which device was enabled last is BY FAR preferable
over just plain not booting.

In all cases where the kernel knows MMCONFIG is broken, no amount of pci_enable_ext_config()
(from drivers or sysfs) will enable MMCONFIG.

>
> Still don't like this approach. It seems like (partially) covering up
> problems rather than solving them.

It's containing them not so much covering. To the point that it becomes diagnosable
and that users have working systems by default.

>

--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org