Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

Tony Camuso
2008-01-29T14:16:29Z

Greg KH wrote:
> On Mon, Jan 28, 2008 at 08:18:04PM -0700, Matthew Wilcox wrote:
>> I'm more optimistic because we've so severely restricted the use of
>> mmconf after these patches that it's unlikely to cause problems. I also
>> hear Vista is now using mmconf, so fewer implementations are going to
>> be buggy at this point.
>
> Hahahaha, oh, that's a good one...
>
> But what about the thousands of implementations out there that are
> buggy?
>
> I'm with Arjan here, I'm very skeptical.
>
> Matthew, with Arjan's patch, is anything that currently works now
> broken? Why do you feel it is somehow "wrong"?
>
> thanks,
>
> greg k-h

Greg,

The problem with Arjan's patch, if I understand it correctly, is that it
requires drivers to make a call to access extended PCI config space.

And, IIRC, Arjan's patch encumbers drivers for all arch's, even those
that have no MMCONFIG problems.

The patches proposed by Loic, Ivan, Matthew, and myself, all address the
problem in an x86-specific manner that is transparent to the drivers.