Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in

Linus Torvalds
2007-12-28T05:33:35Z

On Thu, 27 Dec 2007, Daniel Barkalow wrote:
>
> I'd actually bet that the hardware bug is actually that any device that
> gives a CRS response the first time will have its Vendor ID appear as 0001
> on subsequent mmconfig accesses, which means that it's actually a bus
> quirk that probably only affects mmconfig access to something in the
> conf1-visible space. The only per-device aspect would be that it uses CRS
> (possibly correctly), and that doesn't mean that mmconfig won't be safe in
> general for the device, or even that it won't be necessary. Actually, we
> already know that per-driver enabling mmconfig is broken: sky2 is one that
> wants to opt in but there are also reports of the Vendor ID 0001 bug with
> it.

Actually, having it be a per-device thing would have fixed this particular
problem, if only because the device probing would have been done without
MMCONFIG (thus avoiding the bug), and then after it has been probed, it
wouldn't have mattered if the driver enabled MMCONFIG for the device,
since it would now have the right ID in "struct pci_device".

Sure, subsequent "lspci" users would still be confused, but the kernel
itself would never have noticed anything strange.

Of course, just doing *all* initial probing without MMCONFIG would also
have fixed it, which is another thing I advocate (regardless of any
per-device setting).

Linus