From: Joe Perches <joe@perches.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
trivial@kernel.org, Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 1/3] Remove unused dependency
Date: Sun, 30 Dec 2007 16:16:10 -0800 [thread overview]
Message-ID: <1199060170.9887.27.camel@localhost> (raw)
In-Reply-To: <20071230220018.GA16557@uranus.ravnborg.org>
On Sun, 2007-12-30 at 23:00 +0100, Sam Ravnborg wrote:
> Can you please remind me what problem you are actually trying to solve here.
> Your current approach it not good - we do not want .c code in include/*
> And what is wrong with the current include path?
It's not a bit deal.
inflate.c is #include'd with different depth "../" prefixes.
Currently, depths 1, 3, 4 and 5 are used.
It seemed neater to take this inflate.c file, which can not
be stand-alone compiled, and move it to somewhere on the
include path so that it may be included via #include <inflate.c>
I was originally trying to make each file in a directory via
for file in $(ls lib/*.c) ; do file=${file%.c}.o ; make $file ; done
and I noticed that inflate.o wasn't made.
cheers, Joe
next prev parent reply other threads:[~2007-12-31 0:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-22 7:02 [PATCH 0/3] Remove lib/inflate.c Joe Perches
2007-12-22 7:02 ` [PATCH 1/3] Remove unused dependency Joe Perches
2007-12-22 7:02 ` [PATCH 2/3] " Joe Perches
2007-12-22 7:02 ` [PATCH 3/3] Remove lib/inflate.c Joe Perches
2007-12-22 8:33 ` [PATCH 1/3] Remove unused dependency Sam Ravnborg
2007-12-22 8:50 ` Joe Perches
2007-12-22 14:31 ` Sam Ravnborg
2007-12-22 19:28 ` Joe Perches
2007-12-30 22:00 ` Sam Ravnborg
2007-12-31 0:16 ` Joe Perches [this message]
2007-12-31 8:20 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199060170.9887.27.camel@localhost \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
--cc=sam@ravnborg.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox