From: Lenny Szubowicz <lszubowi@redhat.com>
To: Tony Luck <tony.luck@gmail.com>
Cc: Anton Vorontsov <cbouatmailru@gmail.com>,
Matt Fleming <matt.fleming@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
n hamaguchi <n.hamaguchi@jp.fujitsu.com>,
Don Zickus <dzickus@redhat.com>
Subject: Re: [PATCH 2/3] acpi: Eliminate console msg if pstore.backend excludes ERST
Date: Fri, 28 Jun 2013 16:57:40 -0400 (EDT) [thread overview]
Message-ID: <1199079191.10029297.1372453060353.JavaMail.root@redhat.com> (raw)
In-Reply-To: <CA+8MBbJrU51R5TMV6m4nhAiz2kZQBOcmkeAkEcg-erJhDwrChA@mail.gmail.com>
----- Original Message -----
> From: "Tony Luck" <tony.luck@gmail.com>
> To: "Lenny Szubowicz" <lszubowi@redhat.com>
> Cc: "Anton Vorontsov" <cbouatmailru@gmail.com>, "Matt Fleming" <matt.fleming@intel.com>, "Linux Kernel Mailing List"
> <linux-kernel@vger.kernel.org>, "n hamaguchi" <n.hamaguchi@jp.fujitsu.com>, "Don Zickus" <dzickus@redhat.com>
> Sent: Friday, June 28, 2013 4:44:51 PM
> Subject: Re: [PATCH 2/3] acpi: Eliminate console msg if pstore.backend excludes ERST
>
> On Fri, Jun 28, 2013 at 1:14 PM, Lenny Szubowicz <lszubowi@redhat.com> wrote:
>
> > - if (pstore_register(&erst_info)) {
> > - pr_info(ERST_PFX "Could not register with
> > persistent store\n");
> > + rc = pstore_register(&erst_info);
> > + if (rc) {
> > + if (rc != -EPERM)
> > + pr_info(ERST_PFX
> > + "Could not register with persistent
> > store\n");
> > + erst_info.buf = NULL;
> > + erst_info.bufsize = 0;
>
> Mismatch between part 1 and part 2 here ... we return -EINVAL if
> our name doesn't match the desired backend ... but you only suppress
> the "Could not register" message for -EPERM
>
> Or am I confused while just looking at patch fragments?
>
> -Tony
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Yes, you are absolutely correct. My [PATCH 1/3] is not what I intended. Thanks!
-Lenny.
next prev parent reply other threads:[~2013-06-28 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 20:14 [PATCH 0/3] acpi: Eliminate misleading erst pstore console message Lenny Szubowicz
2013-06-28 20:14 ` [PATCH 1/3] pstore: Return unique error if backend registration excluded by kernel param Lenny Szubowicz
2013-06-28 20:14 ` [PATCH 2/3] acpi: Eliminate console msg if pstore.backend excludes ERST Lenny Szubowicz
2013-06-28 20:44 ` Tony Luck
2013-06-28 20:57 ` Lenny Szubowicz [this message]
2013-06-28 20:14 ` [PATCH 3/3] efivars: If pstore_register fails, free unneeded pstore buffer Lenny Szubowicz
2013-06-28 22:42 ` [PATCH 0/3] acpi: Eliminate misleading erst pstore console message Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199079191.10029297.1372453060353.JavaMail.root@redhat.com \
--to=lszubowi@redhat.com \
--cc=cbouatmailru@gmail.com \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=n.hamaguchi@jp.fujitsu.com \
--cc=tony.luck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox