From: Joe Perches <joe@perches.com>
To: Helge Deller <deller@gmx.de>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Subject: Re: [PATCH] add gcc printf format checks
Date: Sun, 06 Jan 2008 08:05:39 -0800 [thread overview]
Message-ID: <1199635539.19634.8.camel@localhost> (raw)
In-Reply-To: <200801061451.22338.deller@gmx.de>
On Sun, 2008-01-06 at 14:51 +0100, Helge Deller wrote:
> [PATCH] add gcc printf format checks
> diff --git a/include/linux/compat.h b/include/linux/compat.h
> index 0e69d2c..ce2038f 100644
> --- a/include/linux/compat.h
> +++ b/include/linux/compat.h
> @@ -232,7 +232,7 @@ extern int put_compat_itimerspec(struct compat_itimerspec __user *dst,
>
> asmlinkage long compat_sys_adjtimex(struct compat_timex __user *utp);
>
> -extern int compat_printk(const char *fmt, ...);
> +extern int compat_printk(const char *fmt, ...) __printf(1,2);
__attribute__((format(printf, 1, 2))) seems to be the preferred
form. 91 to 1.
I think __printf should be removed from gcc-compiler.h
and the only use in include/linux/marker.h converted.
next prev parent reply other threads:[~2008-01-06 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 13:51 [PATCH] add gcc printf format checks Helge Deller
2008-01-06 16:05 ` Joe Perches [this message]
[not found] ` <200801061858.50975.deller@gmx.de>
2008-01-07 19:14 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199635539.19634.8.camel@localhost \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox