From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: Improve hackbench
Date: Mon, 07 Jan 2008 09:27:39 +0800 [thread overview]
Message-ID: <1199669259.3298.80.camel@ymzhang> (raw)
In-Reply-To: <75b66ecd0801040444y4d698d7fh9caf52955b2b6aad@mail.gmail.com>
On Fri, 2008-01-04 at 07:44 -0500, Lee Revell wrote:
> On Jan 4, 2008 3:10 AM, Ingo Molnar <mingo@elte.hu> wrote:
> > http://redhat.com/~mingo/cfs-scheduler/tools/hackbench.c
> >
>
> Why not lose the #ifdef and just use PTHREAD_STACK_MIN?
That's a good idea.
Thanks,
-yanmin
---
--- hackbench.c.orig 2008-01-10 08:24:36.000000000 +0800
+++ hackbench.c 2008-01-10 08:25:12.000000000 +0800
@@ -151,10 +151,8 @@ pthread_t create_worker(void *ctx, void
if (pthread_attr_init(&attr) != 0)
barf("pthread_attr_init:");
-#ifndef __ia64__
- if (pthread_attr_setstacksize(&attr, (size_t)(16*1024)) != 0)
+ if (pthread_attr_setstacksize(&attr, PTHREAD_STACK_MIN) != 0)
barf("pthread_attr_setstacksize");
-#endif
if ((err=pthread_create(&childid, &attr, func, ctx)) != 0) {
fprintf(stderr, "pthread_create failed: %s (%d)\n", strerror(err), err);
prev parent reply other threads:[~2008-01-07 1:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 6:06 Improve hackbench Zhang, Yanmin
2008-01-04 8:10 ` Ingo Molnar
2008-01-04 11:51 ` Török Edwin
2008-01-04 12:54 ` Ingo Molnar
2008-01-07 1:10 ` Zhang, Yanmin
2008-01-04 12:44 ` Lee Revell
2008-01-07 1:27 ` Zhang, Yanmin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199669259.3298.80.camel@ymzhang \
--to=yanmin_zhang@linux.intel.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox