Re: [PATCH -mm 2/2] kexec/i386: kexec page table code clean up - page table setup in C

["Huang, Ying" <ying.huang@intel.com>]

On Wed, 2008-01-09 at 20:05 -0500, Vivek Goyal wrote:
> On Wed, Jan 09, 2008 at 10:57:50AM +0800, Huang, Ying wrote:
> > This patch transforms the kexec page tables setup code from asseumbler
> > code to iC code in machine_kexec_prepare. This improves readability and
> > reduces code line number.
> > 
> 
> I think this will create issues for Xen. Initially page table setup
> was in C but Xen Guests could not modify the page tables. I think Xen
> folks implemented a hypercall where they passed all the page table pages
> and the control pages and then hypervisor executed the control page(which
> in turn setup the page tables). I think that's why page table setup
> code is on the control page in assembly.
> 
> You might want to go through Xen kexec implementation and dig through
> kexec mailing list archive.

OK, I will check the Xen kexec implementation.

> CCing Magnus and Horms. They had done the page tables related changes
> for Xen.

Best Regards,
Huang Ying