From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Andre Noll <maan@systemlinux.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Richard Knutsson <ricknu-0@student.ltu.se>
Subject: Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl
Date: Thu, 10 Jan 2008 12:54:58 -0600 [thread overview]
Message-ID: <1199991298.3141.75.camel@localhost.localdomain> (raw)
In-Reply-To: <20080110180529.GA32640@skl-net.de>
On Thu, 2008-01-10 at 19:05 +0100, Andre Noll wrote:
> [Resent with proper subject and to additional recipients]
>
> This patch against linus-current is compile-tested on x86 and x86-64.
>
> Please review
This is rather long. For the utility of what you've just done, what's
wrong with just making the .unlocked_ioctl point to sg_unlocked_ioctl()
and doing:
sg_unlocked_ioctl()
int rc;
lock_kernel();
rc = sg_ioctl();
unlock_kernel();
return rc;
}
Really, all this is doing is open coding what the ioctl handler is doing
anyway, isn't it? in which case, why bother to change it at all?
James
next prev parent reply other threads:[~2008-01-10 18:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 18:05 [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl Andre Noll
2008-01-10 18:54 ` James Bottomley [this message]
2008-01-10 18:59 ` Andi Kleen
2008-01-10 19:03 ` Matthew Wilcox
2008-01-10 19:21 ` Andi Kleen
2008-01-10 19:03 ` James Bottomley
2008-01-10 19:32 ` Andi Kleen
2008-01-10 19:33 ` Matthew Wilcox
2008-01-10 19:38 ` Andi Kleen
2008-01-10 19:07 ` Andre Noll
2008-01-10 19:29 ` Andi Kleen
2008-01-10 19:45 ` Andre Noll
2008-01-10 20:09 ` James Bottomley
2008-01-10 20:13 ` Boaz Harrosh
2008-01-10 20:40 ` Andre Noll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199991298.3141.75.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=andi@firstfloor.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maan@systemlinux.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox