[PATCH] drm/sched/tests: Remove redundant header files

[PATCH] drm/sched/tests: Remove redundant header files

[Liao Yuanhong]

The header file <linux/atomic.h> is already included on line 8. Remove the
redundant include.

Fixes: 5a99350794fec ("drm/sched: Add scheduler unit testing infrastructure and some basic tests")
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
 drivers/gpu/drm/scheduler/tests/sched_tests.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/scheduler/tests/sched_tests.h b/drivers/gpu/drm/scheduler/tests/sched_tests.h
index 63d4f2ac7074..e25b8b9b80eb 100644
--- a/drivers/gpu/drm/scheduler/tests/sched_tests.h
+++ b/drivers/gpu/drm/scheduler/tests/sched_tests.h
@@ -11,7 +11,6 @@
 #include <linux/hrtimer.h>
 #include <linux/ktime.h>
 #include <linux/list.h>
-#include <linux/atomic.h>
 #include <linux/mutex.h>
 #include <linux/types.h>
 
-- 
2.34.1

Re: [PATCH] drm/sched/tests: Remove redundant header files

[Tvrtko Ursulin]

On 19/08/2025 15:26, Liao Yuanhong wrote:
> The header file <linux/atomic.h> is already included on line 8. Remove the
> redundant include.
> 
> Fixes: 5a99350794fec ("drm/sched: Add scheduler unit testing infrastructure and some basic tests")
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
>   drivers/gpu/drm/scheduler/tests/sched_tests.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/tests/sched_tests.h b/drivers/gpu/drm/scheduler/tests/sched_tests.h
> index 63d4f2ac7074..e25b8b9b80eb 100644
> --- a/drivers/gpu/drm/scheduler/tests/sched_tests.h
> +++ b/drivers/gpu/drm/scheduler/tests/sched_tests.h
> @@ -11,7 +11,6 @@
>   #include <linux/hrtimer.h>
>   #include <linux/ktime.h>
>   #include <linux/list.h>
> -#include <linux/atomic.h>
>   #include <linux/mutex.h>
>   #include <linux/types.h>
>   

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>

Regards,

Tvrtko

Re: [PATCH] drm/sched/tests: Remove redundant header files

[Markus Elfring]

> The header file <linux/atomic.h> is already included on line 8. Remove the
> redundant include.

You would like to omit a duplicate #include directive, don't you?
Will a corresponding refinement become helpful for the summary phrase
and change description?

Regards,
Markus

Re: [PATCH] drm/sched/tests: Remove redundant header files

[Philipp Stanner]

On Tue, 2025-08-19 at 18:15 +0200, Markus Elfring wrote:
> > The header file <linux/atomic.h> is already included on line 8. Remove the
> > redundant include.
> 
> You would like to omit a duplicate #include directive, don't you?
> Will a corresponding refinement become helpful for the summary phrase
> and change description?

I don't understand what you mean. Can you elaborate?

Both patch content and description are completely fine as far as I'm
concerned.

P.

> 
> Regards,
> Markus

Re: drm/sched/tests: Remove redundant header files

[Markus Elfring]

>>> The header file <linux/atomic.h> is already included on line 8. Remove the
>>> redundant include.
>>
>> You would like to omit a duplicate #include directive, don't you?

The change intention is probably clear.


>> Will a corresponding refinement become helpful for the summary phrase
>> and change description?
> 
> I don't understand what you mean. Can you elaborate?
> 
> Both patch content and description are completely fine as far as I'm concerned.

How do you think about to distinguish better between the deletion of header files
and an adjustment for a repeated preprocessor directive?

Regards,
Markus

Re: drm/sched/tests: Remove redundant header files

[Philipp Stanner]

On Mon, 2025-08-25 at 12:48 +0200, Markus Elfring wrote:
> > > > The header file <linux/atomic.h> is already included on line 8. Remove the
> > > > redundant include.
> > > 
> > > You would like to omit a duplicate #include directive, don't you?
> 
> The change intention is probably clear.
> 
> 
> > > Will a corresponding refinement become helpful for the summary phrase
> > > and change description?
> > 
> > I don't understand what you mean. Can you elaborate?
> > 
> > Both patch content and description are completely fine as far as I'm concerned.
> 
> How do you think about to distinguish better between the deletion of header files
> and an adjustment for a repeated preprocessor directive?

The patch is very trivial and the commit message is perfectly fine.


Applied it to drm-misc-next

Thx
P.


> 
> Regards,
> Markus