public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Hwang <leon.hwang@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	John Fastabend <john.fastabend@gmail.com>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Christian Brauner <brauner@kernel.org>,
	Seth Forshee <sforshee@kernel.org>,
	Yuichiro Tsuji <yuichtsu@amazon.com>,
	Andrey Albershteyn <aalbersh@redhat.com>,
	Willem de Bruijn <willemb@google.com>,
	Jason Xing <kerneljasonxing@gmail.com>,
	Tao Chen <chen.dylane@linux.dev>,
	Mykyta Yatsenko <yatsenko@meta.com>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	Anton Protopopov <a.s.protopopov@gmail.com>,
	Amery Hung <ameryhung@gmail.com>, Rong Tao <rongtao@cestc.cn>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux API <linux-api@vger.kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK"
	<linux-kselftest@vger.kernel.org>,
	kernel-patches-bot@fb.com
Subject: Re: [PATCH bpf-next v9 9/9] selftests/bpf: Add tests to verify map create failure log
Date: Thu, 5 Feb 2026 11:53:40 +0800	[thread overview]
Message-ID: <11bb515b-35fd-44f3-9647-9c39580ce6a1@linux.dev> (raw)
In-Reply-To: <CAADnVQLXWQ8Miq2WBoXRDsEVP1QPwk=a5=Rj_uPN+9qKHZZmZw@mail.gmail.com>



On 5/2/26 04:14, Alexei Starovoitov wrote:
> On Mon, Feb 2, 2026 at 6:43 AM Leon Hwang <leon.hwang@linux.dev> wrote:
>>
>> +
>> +#define BPF_LOG_FIXED  8
>> +
>> +static void test_map_create(enum bpf_map_type map_type, const char *map_name,
>> +                           struct bpf_map_create_opts *opts, const char *exp_msg)
>> +{
>> +       const int key_size = 4, value_size = 4, max_entries = 1;
>> +       char log_buf[128];
>> +       int fd;
>> +       LIBBPF_OPTS(bpf_log_opts, log_opts);
>> +
>> +       log_buf[0] = '\0';
>> +       log_opts.log_buf = log_buf;
>> +       log_opts.log_size = sizeof(log_buf);
>> +       log_opts.log_level = BPF_LOG_FIXED;
> 
> Why? Which part of the test needs the log with this flag?

BPF_LOG_FIXED looks odd here.

This test sets 'log_level = BPF_LOG_FIXED' to match the behavior of
bpf_vlog_init() as initialized by bpf_log_attr_create_vlog() in
patch #7. BPF_LOG_FIXED is intended to be the default log_level
there.

Thanks,
Leon





  reply	other threads:[~2026-02-05  3:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 14:40 [PATCH bpf-next v9 0/9] bpf: Extend BPF syscall with common attributes support Leon Hwang
2026-02-02 14:40 ` [PATCH bpf-next v9 1/9] " Leon Hwang
2026-02-02 14:40 ` [PATCH bpf-next v9 2/9] libbpf: Add support for extended bpf syscall Leon Hwang
2026-02-04 19:48   ` Andrii Nakryiko
2026-02-02 14:40 ` [PATCH bpf-next v9 3/9] bpf: Refactor reporting log_true_size for prog_load Leon Hwang
2026-02-04 19:48   ` Andrii Nakryiko
2026-02-05  2:20     ` Leon Hwang
2026-02-02 14:40 ` [PATCH bpf-next v9 4/9] bpf: Add syscall common attributes support " Leon Hwang
2026-02-04 19:48   ` Andrii Nakryiko
2026-02-05  3:42     ` Leon Hwang
2026-02-05 22:18       ` Andrii Nakryiko
2026-02-06  2:45         ` Leon Hwang
2026-02-02 14:40 ` [PATCH bpf-next v9 5/9] bpf: Refactor reporting btf_log_true_size for btf_load Leon Hwang
2026-02-02 14:40 ` [PATCH bpf-next v9 6/9] bpf: Add syscall common attributes support " Leon Hwang
2026-02-02 14:40 ` [PATCH bpf-next v9 7/9] bpf: Add syscall common attributes support for map_create Leon Hwang
2026-02-02 14:40 ` [PATCH bpf-next v9 8/9] libbpf: " Leon Hwang
2026-02-04 19:48   ` Andrii Nakryiko
2026-02-05  3:45     ` Leon Hwang
2026-02-02 14:40 ` [PATCH bpf-next v9 9/9] selftests/bpf: Add tests to verify map create failure log Leon Hwang
2026-02-04 20:14   ` Alexei Starovoitov
2026-02-05  3:53     ` Leon Hwang [this message]
2026-02-05 23:18       ` Alexei Starovoitov
2026-02-06  2:50         ` Leon Hwang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11bb515b-35fd-44f3-9647-9c39580ce6a1@linux.dev \
    --to=leon.hwang@linux.dev \
    --cc=a.s.protopopov@gmail.com \
    --cc=aalbersh@redhat.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=ameryhung@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brauner@kernel.org \
    --cc=chen.dylane@linux.dev \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kernel-patches-bot@fb.com \
    --cc=kerneljasonxing@gmail.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=rongtao@cestc.cn \
    --cc=sdf@fomichev.me \
    --cc=sforshee@kernel.org \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=willemb@google.com \
    --cc=yatsenko@meta.com \
    --cc=yonghong.song@linux.dev \
    --cc=yuichtsu@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox