From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Thomas Fourier <fourier.thomas@gmail.com>,
Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] pch_uart: Fix dma_sync_sg_for_device() nents value
Date: Tue, 1 Jul 2025 07:15:08 +0200 [thread overview]
Message-ID: <11c0c230-7a19-460c-99cb-18caf62aaedc@kernel.org> (raw)
In-Reply-To: <aGKNaKvndRhQhwwE@smile.fi.intel.com>
On 30. 06. 25, 15:13, Andy Shevchenko wrote:
> On Mon, Jun 30, 2025 at 03:01:01PM +0200, Jiri Slaby wrote:
>> On 30. 06. 25, 14:10, Thomas Fourier wrote:
>>> The dma_sync_sg_for_device() functions should be called with the same
>>> nents as the dma_map_sg(), not the value the map function returned.
>>
>> Care to explain why do you intend to sync more than mapped? "should be
>> called" is way to vague.
>
> It's documented as the correct use of the DMA streaming API.
> Should we go deeper and understand why?
That's IMO enough if he put/referenced this in the commit log...
--
js
suse labs
prev parent reply other threads:[~2025-07-01 5:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 12:10 [PATCH v2] pch_uart: Fix dma_sync_sg_for_device() nents value Thomas Fourier
2025-06-30 12:49 ` Greg KH
2025-06-30 13:01 ` Jiri Slaby
2025-06-30 13:13 ` Andy Shevchenko
2025-07-01 5:15 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11c0c230-7a19-460c-99cb-18caf62aaedc@kernel.org \
--to=jirislaby@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fourier.thomas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tomoya-linux@dsn.okisemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox