From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>,
Melody Olvera <quic_molvera@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Souradeep Chowdhury <quic_schowdhu@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>,
Elson Serrao <quic_eserrao@quicinc.com>
Cc: cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: soc: qcom: eud: Update compatible strings for eud
Date: Wed, 21 Aug 2024 08:48:00 +0200 [thread overview]
Message-ID: <11ca366c-7788-41d0-bf47-4f31c1ee2626@kernel.org> (raw)
In-Reply-To: <e663d19a-0ad1-4dfc-903b-ff2012796d84@kernel.org>
On 20/08/2024 21:19, Konrad Dybcio wrote:
> On 20.08.2024 8:21 PM, Melody Olvera wrote:
>>
>>
>> On 8/14/2024 3:09 PM, Trilok Soni wrote:
>>> On 8/14/2024 1:25 PM, Konrad Dybcio wrote:
>>>>> Unfortunately, no. We considered several options, but none guarantee that we will avoid
>>>>> a crash if we try non-securely. The secure call also won't give a specific error if it fails either
>>>>> (for security reasons) so we can't know if a secure access failed because it's supposed to be
>>>>> accessed non-securely or for another reason; hence this approach. If there's
>>>>> another way to achieve this functionality that might be better, I'm all ears.
>>>> Can we read some fuse values and decide based on that?
>>> In most of the cases, these fuse values are not allowed to be read
>>> from the Linux, so that will be another problem. Melody can check
>>> if there is any fuse values around here and possible to read them
>>> through Linux.
>>>
>>
>> I double-checked, but there really isn't any kind of fuse or anything we can read to determine
>> how we need to access these registers. I remembered checking before authoring these patches,
>> but I wanted to just make sure before responding here.
>
> Well in that case I suppose a new compatible / property (please voice
> your opinion Krzysztof) is necessary after all.. Thanks for making sure
You mean the "secure" part? Sure, I don't object that, although
(repeating as usual) I am not in favor of it in the first place, be
cause you should use only SoC compatibles.
The objection here was for dropping specific front compatible, without
any relevant explanation.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-21 6:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 18:32 [PATCH v1 0/3] Add compatibles for different eud access modes Melody Olvera
2024-08-07 18:32 ` [PATCH v1 1/3] dt-bindings: soc: qcom: eud: Update compatible strings for eud Melody Olvera
2024-08-08 11:00 ` Krzysztof Kozlowski
2024-08-13 20:03 ` Melody Olvera
2024-08-14 6:15 ` Krzysztof Kozlowski
2024-08-14 10:30 ` Konrad Dybcio
2024-08-14 17:33 ` Melody Olvera
2024-08-14 20:25 ` Konrad Dybcio
2024-08-14 22:09 ` Trilok Soni
2024-08-20 18:21 ` Melody Olvera
2024-08-20 19:19 ` Konrad Dybcio
2024-08-21 6:48 ` Krzysztof Kozlowski [this message]
2024-08-21 17:27 ` Konrad Dybcio
2024-08-14 17:20 ` Melody Olvera
2024-08-07 18:32 ` [PATCH v1 2/3] usb: misc: qcom_eud: Access mode manager through secure calls Melody Olvera
2024-08-07 18:32 ` [PATCH v1 3/3] arm64: dts: qcom: sc7280: Update eud compatible string Melody Olvera
2024-08-08 11:03 ` Krzysztof Kozlowski
2024-08-13 20:05 ` Melody Olvera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11ca366c-7788-41d0-bf47-4f31c1ee2626@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_eserrao@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_satyap@quicinc.com \
--cc=quic_schowdhu@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox