From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f99.google.com (mail-vs1-f99.google.com [209.85.217.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F528366DD3 for ; Wed, 1 Jul 2026 18:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782931160; cv=none; b=jki6xaKFXXsaU60hsYZDBfAJbSGnKYH3qBS+zatNnffE/WJle/emi1kHtZ0x83dD5pGOtjoESzHfQg6dJ55PQd2EVo8yID+e+Oss43B/Gx18vvAa7ijyfrwUK8Kiskg90uRsErD13F6sTrhpn9hBL87CDLPS36ceMlTU5I4xKr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782931160; c=relaxed/simple; bh=Umva64T0GNMd81yvWTwLoVqmHq79H/NFxEmArtYx5qU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TRU5rSwxGrWHN+xuJSdPDkxdjdk+GxsfgsgbB3sEH1wCjydQgZjjURfaz7BsfLVPun9L2yoEu6LjxjdZTa9phFpCqlvh//vkqr1m6Pa28qDbyc0tv8ihjA/fv52wiwl/0d0pprGOnNE7YWJy4toV1o/v9xviZjiuT7jaH/L+USs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=agDxFpPo; arc=none smtp.client-ip=209.85.217.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="agDxFpPo" Received: by mail-vs1-f99.google.com with SMTP id ada2fe7eead31-73a75f251a7so387033137.2 for ; Wed, 01 Jul 2026 11:39:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782931158; x=1783535958; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S/JxzyIbMWOBgcLE6PUDXiCIrbfQPnTTq4sO8ZawTQs=; b=QohQaXckhvPDMW0ca9PEO4SEevaLwBywNuvYcDhJb2r9u8dwTo4FQI4deKTvS/11af 3FmmqyXloxDiwkRMicpo2xKwDetfSMFs+onz+PvyUqyCWO9ZXRoU6ZHjvdkUxdetFoAB 7/IzFA42C4B0Bpbkia08XHKDo5Pm6D/8hhEnLFYr6+WYb3tl7sie7KwT+1foPkcxedSB uhvz/wqKE/xaxp/GFryMl+HJ0fPsjlX6VKjenp9MCfA8e9kS7FLel0G/AT2FJa9lX1Dz PxI3bpC1a9Lj+vxZ36+IgMglFW7lq7qvuAKDaSjja1m9sQoVrUgYHFEVg16quGRxEYWA 193w== X-Forwarded-Encrypted: i=1; AHgh+RpLIO5AuGYB6v76Ka4bApR9NhlTGhfHQhksxcN+/TibBBnCuXb6gCKt/fPe8f93vXMe1amsJkwr6ySdAX8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywr0F6lPjKhPnW2KdioyEOzGghByiEtUHdD+2iiCZ6WA0W24xn4 C0PAlE0kmDmdAaIxPCjxWKS2FLiv7Fj00jnzVxpdcdGvYkbGgcFNTlQGzBq+Lgyuu56t/JXBC2a v2E1kbw6Yye1AZOR24X/5Ui8ig4/smiw85JjlsFLALVtAI7Py1YOoW15sQmDPzG+1+FMSu83me9 LQB65vwTtxGiZZsN+AXV07Jovk37vgNq3V95UgKijBddDOI60Bec5V3o2ERTNEha7QkD8P0YlJc 30ikGspwVNgGuy86v6TWmXU X-Gm-Gg: AfdE7ckWIUvKQMCGmAEjw1pBbps4LOEIqixDul8QuA06b0+92ZQ9YKyF/yf/seObbDu nEfwUhCtW+vGJXz1FjoZcGb+0Ak5X7pttDrVz/9XnGZg2qdP1rLOlQfqDTxRJkWrgabp8mtQYIM GXjW517YEv0ya775VOmJnkRx1y/cEQgri48H/e+2D8pxWg3klLMeUZ8W/SEFgqyYLTCB12AymJb 7OFUIU5jy6R+TFdQ4PluzBdtTh5N+QRBXWJZDQbQsN83NXfeT3YOeTJgzGrSGETQARHj+w1N8Dx FzcIHgf5HKKoeItiVOfLnGjJUbzzuJooTm4oDDa95/X2MWk6U7y5veu3QFpfz9MUE0XywUsquml F48D5Ic43AxNxvEXxnwRqeYnCxWTt8naB7Ly0zA/2OGDECUFAun6gjMFmmYRQNEkTr1piQVfPfu qdqARu5fzH29IgBtldPW17bT/6YGiWJ3wiri+XAIXh4dPrkAKdFSQ= X-Received: by 2002:a05:6102:419e:b0:738:394e:a59e with SMTP id ada2fe7eead31-73dc03b0e17mr1012367137.25.1782931157754; Wed, 01 Jul 2026 11:39:17 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-11.dlp.protect.broadcom.com. [144.49.247.11]) by smtp-relay.gmail.com with ESMTPS id ada2fe7eead31-73e19f3549esm33145137.9.2026.07.01.11.39.17 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jul 2026 11:39:17 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-4960487333eso1299250b6e.3 for ; Wed, 01 Jul 2026 11:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1782931157; x=1783535957; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S/JxzyIbMWOBgcLE6PUDXiCIrbfQPnTTq4sO8ZawTQs=; b=agDxFpPoCxj5nFAOnsrIU8kJK/zWvEwAydS9XBynwMqTpdmQ8OH54S/Q5iZ7fl4s2n pyhMqQqZaOiqlhuUpKv2C/DjhnW4vR4m4C9Uym5LWijAUuxV1EasSrts6NTQ8zhLFmmB TZ9RSvjJrqQ6SQnpE3FEu0yQvoNy1IU9DkgkU= X-Forwarded-Encrypted: i=1; AFNElJ/r91Qoc1+TuguVyfVtZU53J0FVJ61g+KfGOTb4SPK7TsoMS/FFmBq1/FEzkUdsYkk6p2fvjNzXVmc3Fgk=@vger.kernel.org X-Received: by 2002:a05:6808:190c:b0:48c:4c00:596a with SMTP id 5614622812f47-4962d70ee64mr1114559b6e.5.1782931157032; Wed, 01 Jul 2026 11:39:17 -0700 (PDT) X-Received: by 2002:a05:6808:190c:b0:48c:4c00:596a with SMTP id 5614622812f47-4962d70ee64mr1114533b6e.5.1782931156582; Wed, 01 Jul 2026 11:39:16 -0700 (PDT) Received: from [10.211.247.235] ([192.19.50.250]) by smtp.gmail.com with ESMTPSA id 5614622812f47-49606ad4774sm1995857b6e.9.2026.07.01.11.39.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 11:39:16 -0700 (PDT) Message-ID: <11cd2e26-1af5-4085-a589-060b96a51076@broadcom.com> Date: Wed, 1 Jul 2026 11:43:34 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/vmwgfx: Fix NULL vs error pointer bug in vmw_prime_import_sg_table() To: Dan Carpenter , Zack Rusin Cc: Broadcom internal kernel review list , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Martin Krastev , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Maaz Mombasawala Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 6/28/26 11:34 PM, Dan Carpenter wrote: > The vmw_prime_import_sg_table() function is expected to return error > pointers on error and not NULL. Otherwise it leads to a NULL dereference > in the caller drm_gem_prime_import_dev(). > > Change the NULL to ERR_PTR(-ENOMEM). > > Fixes: b32233acceff ("drm/vmwgfx: Fix prime import/export") > Signed-off-by: Dan Carpenter > --- > drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c > index 39f8c46550c2..f25db04f8777 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c > @@ -184,7 +184,7 @@ struct drm_gem_object *vmw_prime_import_sg_table(struct drm_device *dev, > { > int ret; > struct vmw_private *dev_priv = vmw_priv(dev); > - struct drm_gem_object *gem = NULL; > + struct drm_gem_object *gem = ERR_PTR(-ENOMEM); > struct vmw_bo *vbo; > struct vmw_bo_params params = { > .domain = (dev_priv->has_mob) ? VMW_BO_DOMAIN_SYS : VMW_BO_DOMAIN_VRAM, LGTM! Reviewed-by: Maaz Mombasawala -- Maaz Mombasawala