public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Vlad Buslov <vladbu@mellanox.com>,
	linux-kselftest@vger.kernel.org, davem@davemloft.net
Cc: lucasb@mojatatu.com, jhs@mojatatu.com, mrv@mojatatu.com,
	linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] tc-testing: flush gact actions on test teardown
Date: Tue, 22 May 2018 09:43:28 -0600	[thread overview]
Message-ID: <11f03b6a-a8c4-e64c-7e2d-fb8218bc6320@kernel.org> (raw)
In-Reply-To: <1526660482-10424-1-git-send-email-vladbu@mellanox.com>

On 05/18/2018 10:21 AM, Vlad Buslov wrote:
> Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
> on teardown. Leaking pipe action causes failures in other tests.
> 
> Add additional teardown command to also flush gact actions.
> 
> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
> ---
>  tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
> index 443c9b3..acb24f7 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/actions/mirred.json
> @@ -44,7 +44,8 @@
>          "matchPattern": "action order [0-9]*: mirred \\(Egress Redirect to device lo\\).*index 2 ref",
>          "matchCount": "1",
>          "teardown": [
> -            "$TC actions flush action mirred"
> +            "$TC actions flush action mirred",
> +            "$TC actions flush action gact"
>          ]
>      },
>      {
> 

I can get this into 4.18-rc1 unless there is a reason for this to go
through net tree.

thanks,
-- Shuah

  reply	other threads:[~2018-05-22 15:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 16:21 [PATCH] tc-testing: flush gact actions on test teardown Vlad Buslov
2018-05-22 15:43 ` Shuah Khan [this message]
2018-05-22 15:49   ` David Miller
2018-05-22 16:10     ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11f03b6a-a8c4-e64c-7e2d-fb8218bc6320@kernel.org \
    --to=shuah@kernel.org \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lucasb@mojatatu.com \
    --cc=mrv@mojatatu.com \
    --cc=vladbu@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox