[PATCH RESEND] irqchip/gic-v3-its: Use the its_invall_cmd descriptor when building INVALL

[PATCH RESEND] irqchip/gic-v3-its: Use the its_invall_cmd descriptor when building INVALL

[Zenghui Yu]

It looks like an obvious mistake to use its_mapc_cmd descriptor when
building the INVALL command block. It so far worked by luck because
both its_mapc_cmd.col and its_invall_cmd.col sit at the same offset of
the ITS command descriptor, but we should not rely on it.

Fixes: cc2d3216f53c ("irqchip: GICv3: ITS command queue")
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---

This patch has been originally posted at:
https://lore.kernel.org/r/20191202071021.1251-1-yuzenghui@huawei.com
but somehow has been missed for 5.5.  So repost it.

 drivers/irqchip/irq-gic-v3-its.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index f71758632f8d..e5a25d97f8db 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -661,7 +661,7 @@ static struct its_collection *its_build_invall_cmd(struct its_node *its,
 						   struct its_cmd_desc *desc)
 {
 	its_encode_cmd(cmd, GITS_CMD_INVALL);
-	its_encode_collection(cmd, desc->its_mapc_cmd.col->col_id);
+	its_encode_collection(cmd, desc->its_invall_cmd.col->col_id);
 
 	its_fixup_cmd(cmd);
 
-- 
2.19.1

Re: [PATCH RESEND] irqchip/gic-v3-its: Use the its_invall_cmd descriptor when building INVALL

[Marc Zyngier]

On 2020-02-03 04:18, Zenghui Yu wrote:
> It looks like an obvious mistake to use its_mapc_cmd descriptor when
> building the INVALL command block. It so far worked by luck because
> both its_mapc_cmd.col and its_invall_cmd.col sit at the same offset of
> the ITS command descriptor, but we should not rely on it.
> 
> Fixes: cc2d3216f53c ("irqchip: GICv3: ITS command queue")
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> 
> This patch has been originally posted at:
> https://lore.kernel.org/r/20191202071021.1251-1-yuzenghui@huawei.com
> but somehow has been missed for 5.5.  So repost it.

Oops, sorry about that. Now applied and pushed out.

         M.
-- 
Jazz is not dead. It just smells funny...