From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62F61157E88 for ; Thu, 16 Jan 2025 08:31:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737016319; cv=none; b=HqMKyeBOH94QKwAhnnmJT6uEL6zpj2RkTGNglNqOiCwfyys4CZBETtgz+BE4wsX6ypWNDkb3d5bEYEzG5KLHVwOVyiYOyQ8uzPjGHzHiUoTm2BuAbxi8+bwZ6OSXhfKYS1S65DbxjuFoBIo6IS6GzCp5YtRhHZ8ElVrkUWJAzNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737016319; c=relaxed/simple; bh=nM3Q7CZXxvDLM64A/7/nEQ//gngY5Eok3yDCRO4vquQ=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=uM764s7nF232q5EMXa5hWYNS1MdnrgPke92mwb4S1wPT9ZtEeGGnT+As90jC9bk8fZO2+kGVrMsasfQDgdRH9mURjMm8S7f2ao14zmqJWuqwAoYsMQLeRzUPLu2JVFh0Dy4xXhX3aTdLhS4wwDRFfK0q7ud3mzycaYIGyNHsN2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q98Qk1Sa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q98Qk1Sa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22A5FC4CED6; Thu, 16 Jan 2025 08:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737016318; bh=nM3Q7CZXxvDLM64A/7/nEQ//gngY5Eok3yDCRO4vquQ=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Q98Qk1SaKAQ+0j09MuNoD375OlLzgR4MHhRxHC/4pqc31xV1KDn7ySLBXNSxkCvdV 2nSSizY1xDC2qFUgPn9qQUgJ1jPTCmSnOwo76U+ULs6iMvgOXVc+XyapuiHNHn76ru 2DVsgntk/L2Evs04b18UU7Jr6HIfuvYuuGidc0Xx+wLTSDGH18pPhIjPhrKHgvq7Ro /jk07ITsY+2SzIKduYSZtrsztUJxyq7ejIkFDzKQ5cLir4OpJrQIaJV7rJmal6yZ/3 Tu5ckx3iXFXKaMnNgiqqwOMkk458+pMvNgcKbzUcvDfmR3ZDNKVQjUnngLy11Niaeo cHy+f8Ub50/JA== Message-ID: <11ffcd03-c3ce-4d2b-8360-1968092f72c1@kernel.org> Date: Thu, 16 Jan 2025 16:31:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, LKML Subject: Re: [PATCH] erofs: fix potential return value overflow of z_erofs_shrink_scan() To: Gao Xiang , linux-erofs@lists.ozlabs.org References: <20250114040058.459981-1-hsiangkao@linux.alibaba.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20250114040058.459981-1-hsiangkao@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/25 12:00, Gao Xiang wrote: > z_erofs_shrink_scan() could return small numbers due to the mistyped > `freed`. > > Although I don't think it has any visible impact. Agreed, it's an extreme case... > > Fixes: 3883a79abd02 ("staging: erofs: introduce VLE decompression support") > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,