From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA42A12E1D9 for ; Sun, 23 Jun 2024 11:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719141012; cv=none; b=W+tav8z4iBloZ56/VH0NE+LXg74MhJulJWQlTmDzqD47qP3TcmIcLvJ3Dfd6q7UZfCg76UULo1j3KukIYhqza0uuYBBeUH4jqyc8rAEMYYUzVs2zFTa2N4LTE+IAWuo9AtTNrDvZQ9yRlfBe98Mav382NG0JPcXuZGRHP0jsKcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719141012; c=relaxed/simple; bh=unFZHIttLBI9tNct9PDlWU0KN4H9FFc22DiGn2t+m+U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HDYw22Ckgi+zNquSf93/GnPYJeyHVqK8W5ZOxCQimX28qKuJA5ICrq++Lf+4PBA+pUMbzc3nOto1uytUBcy+WHCOAgdYiXXqmomApqnnjQ6yqgVgjK8Fru1rHrSydTi8Hs8CUam+c0MrCBfwJCtpM5ENsNHzINqVQUcxVgQSCZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Ridj1i4s; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ridj1i4s" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-42490f21bd9so316065e9.0 for ; Sun, 23 Jun 2024 04:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719141008; x=1719745808; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/DTecXJvjNODhxPYAbYa8VnbugUzgN9fw88ySISIgZM=; b=Ridj1i4sT60a3q22QLRu7ou8eeZyhHsQ3RoFasgkv4DQ+A53OrJBA8ELhyUdXFvJdS 9phBjLNEQOYQOQMwK6Fo4xYziDScFcMGU5p8GDjymy84QoPQVBesPLeSgB0HxYdlmL+Q 6xJpJFjxKTwx7ApRXVdE8FYo49OkP1b3t1fJ6U/c6c/ZXnHDfw8uz+f2fMSp+nOzaaDZ 6eGauYzEQfyaIzk6YWQGzeojBspjvxsn1JxnkWjAvGoNvcVJALce90DBcQoKl60vV5dY yyDHJELfWjZWVcjtTXuUHNB3bfY1elqFmIQRPAKri4K9GpZ3agka7XL9Sqc/oMNjUfCo XnCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719141008; x=1719745808; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/DTecXJvjNODhxPYAbYa8VnbugUzgN9fw88ySISIgZM=; b=a5Ad6F+ZmDlp9z8+jO/Lli8J5QNyzuRh3+VIqzETf/Dn/szH5o6Cs4atiWrlMzx34s XxphFToXXVzeSwGgkDB/PFhVPdOVpmp4sNWOpEJr4XOdFS0hvFZsRKAtKCbeKo/9n5UA TjItVZUVnqjeYwYXPJqsMuHty9CyVJjBYU7osEm7DT8V0HFgMGntLxYaC8oR7VMY4kx5 ydr+o9bSEkfvI02Ri5mi8OtNbJB2FrFG80l0pD3VT1X7B+9XlP8l4HnjtGHlPap4m7Yc fMErrbtgKTO+9xcNQX3VO+aHZlVC+PHBOEVR4fx85cTQzybFlmDss+pLHWaWFncIzN6D xX9w== X-Forwarded-Encrypted: i=1; AJvYcCVgRYVmTdhkpBXr9G00jnfy+43Fd9f1rOPLaRiakekYfl0jpKMMorEQkA3hRlUmjQsxnqX1cZAMcJgr5XNzq0HONhpCRak9bM5E9Vyx X-Gm-Message-State: AOJu0YzmeOm+5Rxc8OfxhcNxw4M1IHHLrfDu+aIpWgDXja7Dg4TQDTe3 iMumWHUC0emK8aKFntrxmF9yriwf8V1hueTVdU9lK1BHzViGCARup/Bk58mWzjo= X-Google-Smtp-Source: AGHT+IFx4moyEsKR5tncGEiz2xcse9WpaDz6d79q8f/CZB6iGUj6DJrTDMQGbeONg8ohV70awS/WgQ== X-Received: by 2002:a05:600c:354f:b0:421:f346:6af6 with SMTP id 5b1f17b1804b1-4248cc5864dmr12124305e9.26.1719141008026; Sun, 23 Jun 2024 04:10:08 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0c54e4sm138269215e9.23.2024.06.23.04.10.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jun 2024 04:10:07 -0700 (PDT) Message-ID: <12000768-e9bf-46de-9159-562d92470eb3@linaro.org> Date: Sun, 23 Jun 2024 12:10:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] media: dt-bindings: media: camss: Add qcom,sc7180-camss binding To: george chan Cc: Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240621-b4-sc7180-camss-v1-0-14937929f30e@gmail.com> <20240621-b4-sc7180-camss-v1-1-14937929f30e@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 22/06/2024 16:31, george chan wrote: > On Fri, Jun 21, 2024 at 7:24 PM Bryan O'Donoghue > wrote: >> >> On 21/06/2024 10:40, George Chan via B4 Relay wrote: >>> + power-domains: >>> + items: >>> + - description: IFE0 GDSC - Image Front End, Global Distributed Switch Controller. >>> + - description: IFE1 GDSC - Image Front End, Global Distributed Switch Controller. >>> + - description: Titan GDSC - Titan ISP Block, Global Distributed Switch Controller. >> >> Please name these power-domains and require them in your yaml, >> remembering to add them into the DTS. > > I can borrow the idea from sdm845-venus-v2 > > @@ -191,6 +190,7 @@ required: > - interrupts > - iommus > - power-domains > + - power-domain-names > - reg > ... > + power-domain-names = "ife0", > + "ife1", > + "top"; Something like this https://git.codelinaro.org/bryan.odonoghue/kernel/-/commit/7626cd2a2a509832c214e538827b91c5dbf1bf09 --- bod